From 00b8622db7b147d9b3c0d157849ad2352bf41b6f Mon Sep 17 00:00:00 2001 From: Uzair Rasheed Date: Thu, 14 Sep 2023 12:15:37 +0500 Subject: [PATCH] Revert "fix: strip off the spaces in mktg url" This reverts commit b7de0b2f79bf9862ebd95879d9f9950b8d37bfe3. --- course_discovery/apps/course_metadata/models.py | 4 ++-- .../apps/course_metadata/tests/test_models.py | 12 ------------ 2 files changed, 2 insertions(+), 14 deletions(-) mode change 100755 => 100644 course_discovery/apps/course_metadata/tests/test_models.py diff --git a/course_discovery/apps/course_metadata/models.py b/course_discovery/apps/course_metadata/models.py index 29818a25e3..35c5ebed2d 100644 --- a/course_discovery/apps/course_metadata/models.py +++ b/course_discovery/apps/course_metadata/models.py @@ -3303,8 +3303,8 @@ def weeks_to_complete_max(self): @property def marketing_url(self): if self.marketing_slug: - path = f'{self.type.slug.lower().strip()}/{self.marketing_slug.strip()}' - return urljoin(self.partner.marketing_site_url_root.strip(), path) + path = f'{self.type.slug.lower()}/{self.marketing_slug}' + return urljoin(self.partner.marketing_site_url_root, path) return None diff --git a/course_discovery/apps/course_metadata/tests/test_models.py b/course_discovery/apps/course_metadata/tests/test_models.py old mode 100755 new mode 100644 index 9839592df7..7830263570 --- a/course_discovery/apps/course_metadata/tests/test_models.py +++ b/course_discovery/apps/course_metadata/tests/test_models.py @@ -2454,18 +2454,6 @@ def test_search(self): query = 'title:' + self.program.title self.assertSetEqual({Program.search(query).first()}, {self.program}) - def test_spaces_must_be_stripped_off_from_marketing_url(self): - """ - Validate that the spaces in the marketing slug must be stripped off while generating marketing url - """ - # updating the attrs with trailing spaces - self.program.marketing_slug = 'test-slug-0 ' - self.program.type.slug = 'test ' - site_root = self.program.partner.marketing_site_url_root - self.program.partner.marketing_site_url_root = site_root + ' ' - - assert self.program.marketing_url.find(' ') == -1 - def test_subject_search(self): """ Verify that the program endpoint correctly handles elasticsearch queries on the subject uuid