From 1593dcdca0b18112a92783261f9f27489b8afe47 Mon Sep 17 00:00:00 2001 From: Rebecca Graber Date: Mon, 21 Jun 2021 08:59:33 -0400 Subject: [PATCH] chore: remove out of date comments for code that is no longer experimental (#3056) --- course_discovery/apps/api/serializers.py | 2 -- course_discovery/apps/api/tests/test_serializers.py | 2 -- course_discovery/apps/api/v1/tests/test_views/test_courses.py | 2 -- course_discovery/apps/api/v1/views/courses.py | 1 - course_discovery/apps/course_metadata/models.py | 2 -- course_discovery/apps/course_metadata/tests/test_models.py | 1 - 6 files changed, 10 deletions(-) diff --git a/course_discovery/apps/api/serializers.py b/course_discovery/apps/api/serializers.py index 9d7ac2f5d7..005505aa7e 100644 --- a/course_discovery/apps/api/serializers.py +++ b/course_discovery/apps/api/serializers.py @@ -1221,7 +1221,6 @@ class Meta(CourseSerializer.Meta): ) -# Experiment WS-1681: Course recommendations class CourseWithRecommendationsSerializer(DynamicFieldsMixin, TimestampModelSerializer): uuid = UUIDField(read_only=True, default=CreateOnlyDefault(uuid4)) recommendations = serializers.SerializerMethodField() @@ -1262,7 +1261,6 @@ class Meta(CourseSerializer.Meta): model = Course fields = ('key', 'uuid', 'title', 'owners', 'image', 'short_description', 'type', 'url_slug', 'course_run_keys', 'marketing_url') -# end experiment code class CatalogCourseSerializer(CourseSerializer): diff --git a/course_discovery/apps/api/tests/test_serializers.py b/course_discovery/apps/api/tests/test_serializers.py index 03f70c3ee3..5d3627f1d1 100644 --- a/course_discovery/apps/api/tests/test_serializers.py +++ b/course_discovery/apps/api/tests/test_serializers.py @@ -2572,7 +2572,6 @@ def test_data(self): self.assertDictEqual(serializer.data, expected) -# Experiment WS-1681: course recommendations class CourseRecommendationSerializerTests(MinimalCourseSerializerTests): serializer_class = CourseRecommendationSerializer @@ -2656,4 +2655,3 @@ def test_exclude_utm(self): SeatFactory.create_batch(2, course_run=course_run) serializer = self.serializer_class(course_with_recs, context={'request': request, 'exclude_utm': 1}) assert serializer.data['recommendations'][0]['marketing_url'] == recommended_course_0.marketing_url -# end experiment code diff --git a/course_discovery/apps/api/v1/tests/test_views/test_courses.py b/course_discovery/apps/api/v1/tests/test_views/test_courses.py index 556287d71d..d4446999cc 100644 --- a/course_discovery/apps/api/v1/tests/test_views/test_courses.py +++ b/course_discovery/apps/api/v1/tests/test_views/test_courses.py @@ -1576,10 +1576,8 @@ def test_html_restricted(self): response = self.client.patch(url, {'full_description': '

Header

'}, format='json') self.assertContains(response, 'Invalid HTML received: h1 tag is not allowed', status_code=400) - # Experiment WS-1681: course recommendations @responses.activate def test_recommendations(self): url = reverse('api:v1:course_recommendations-detail', kwargs={'key': self.course.key}) response = self.client.get(url) assert response.status_code == 200 - # end experiment code diff --git a/course_discovery/apps/api/v1/views/courses.py b/course_discovery/apps/api/v1/views/courses.py index 2ed3ab9d00..e66bf1db18 100644 --- a/course_discovery/apps/api/v1/views/courses.py +++ b/course_discovery/apps/api/v1/views/courses.py @@ -500,7 +500,6 @@ def retrieve(self, request, *args, **kwargs): return super().retrieve(request, *args, **kwargs) -# Experiment WS-1681: Course recommendations class CourseRecommendationViewSet(RetrieveModelMixin, viewsets.GenericViewSet): filter_backends = (DjangoFilterBackend, ) lookup_field = 'key' diff --git a/course_discovery/apps/course_metadata/models.py b/course_discovery/apps/course_metadata/models.py index a19aeac230..99cabc3503 100644 --- a/course_discovery/apps/course_metadata/models.py +++ b/course_discovery/apps/course_metadata/models.py @@ -1141,7 +1141,6 @@ def advertised_course_run(self): return advertised_course_run - # Experiment WS-1681: Course recommendations def has_marketable_run(self): return any(run.is_marketable for run in self.course_runs.all()) @@ -1176,7 +1175,6 @@ def recommendations(self): deduped.append(course) seen.add(course) return deduped - # End Experiment WS-1681: Course recommendations class CourseEditor(TimeStampedModel): diff --git a/course_discovery/apps/course_metadata/tests/test_models.py b/course_discovery/apps/course_metadata/tests/test_models.py index c9949914b3..c81381601f 100644 --- a/course_discovery/apps/course_metadata/tests/test_models.py +++ b/course_discovery/apps/course_metadata/tests/test_models.py @@ -2408,7 +2408,6 @@ def test_slug_with_partner_mismatch(self): url_slug=slug_object.url_slug)] -# Experiment WS-1681: Course recommendations class TestCourseRecommendations(TestCase): def setUp(self): super().setUp()