Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Node JS from 16 to 18 #1969

Closed
Tracked by #243
abdullahwaheed opened this issue Mar 16, 2023 · 4 comments
Closed
Tracked by #243

Upgrade Node JS from 16 to 18 #1969

abdullahwaheed opened this issue Mar 16, 2023 · 4 comments
Labels
needs maintainer attention Issue or PR specifically needs the attention of the maintainer.

Comments

@abdullahwaheed
Copy link
Contributor

Abstract
Node 16's support will end on September 11, 2023. So we have to upgrade node JS to v18 before that.

Extras
Project should use .nvmrc to have a consistent node version
We have to update Readme accordingly.

Upgrade Node JS from 16 to 18
@arbrandes arbrandes mentioned this issue May 23, 2023
Closed
@abdullahwaheed
Copy link
Contributor Author

since its UI is deprecating, FED-BOM isn't upgrading node in this repo. If owning team wants to upgrade it to node 18, FED-BOM can assist them to do so

@abdullahwaheed abdullahwaheed removed their assignment Aug 1, 2023
@hurtstotouchfire hurtstotouchfire added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Aug 30, 2023
@jsnwesson
Copy link
Contributor

Currently being handled with this PR, which is scheduled to be reviewed by the team.

@justinhynes
Copy link
Contributor

Made some progress on this. I tested it locally and things looked good. However, the PR has a few conflicts that need to be resolved. Once these are resolved we can merge it and close this out.

@arbrandes
Copy link

Looks like the PR merged! Congrats, and thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs maintainer attention Issue or PR specifically needs the attention of the maintainer.
Projects
Aperture-Maintained
Status: Done
Frontend Working Group
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
5 participants
@arbrandes @hurtstotouchfire @justinhynes @abdullahwaheed @jsnwesson