Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting Toolbar Blocking Text Input #1636

Open
edschema opened this issue Jan 28, 2025 · 6 comments · Fixed by #1646
Open

Formatting Toolbar Blocking Text Input #1636

edschema opened this issue Jan 28, 2025 · 6 comments · Fixed by #1646
Labels
bug Report of or fix for something that isn't working as intended

Comments

@edschema
Copy link

The formatting toolbar blocks text entry boxes for Hints and Answers in the problem editor. This happens when creating a problem block in both a library and within a course.

@bradenmacdonald

Image

@bradenmacdonald bradenmacdonald added the bug Report of or fix for something that isn't working as intended label Jan 28, 2025
@bradenmacdonald
Copy link
Contributor

After looking at this, I think the bug is actually a bit different: the formatting toolbar is only supposed to be shown above the answer fields when some text in the answer field is selected (I think), but it's also showing when the user focuses on the field and it has no text at all (and no selection).

A simple fix would be ensuring that it only appears if some text is selected, not when the field is empty. In that case, it already appears in the correct position:

Image

Does that make sense? Or should it appear even when no text is selected, but just higher up?

@bradenmacdonald
Copy link
Contributor

Hmm, are answers allowed to contain bulleted lists, images, and other stuff? Then I guess we do need the toolbar visible. I'll see if I can just move it up.

@marcotuts
Copy link

I don't know that we want that to be visible all the time IMO - Having this appear only on highlight seems like a fine solution for now - @bradenmacdonald. I think the formatting being visible on each visually complicates this editing a fair bit when I expect formatting to be rare

@pomegranited
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@pomegranited pomegranited reopened this Feb 14, 2025
@pomegranited pomegranited moved this to Ready for AC testing in Libraries Overhaul Feb 14, 2025
@edschema
Copy link
Author

The formatting toolbar with full options appears on highlight only as expected. However, the toolbar still appears with image/ bulleted list on click, and blocks the text entry box.

Image

@bradenmacdonald
Copy link
Contributor

@edschema I agree it's not ideal, but I was asked to leave the image tool in for now, on this thread: https://openedx.slack.com/archives/CR0UMU0QP/p1738366344282679

Unfortunately there aren't a lot of options for improving this without a major change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Status: Ready for AC testing
Development

Successfully merging a pull request may close this issue.

4 participants