Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In k8s, use a secret instead of an env var for NEO4J_AUTH #38

Open
kdmccormick opened this issue Mar 9, 2023 · 2 comments
Open

In k8s, use a secret instead of an env var for NEO4J_AUTH #38

kdmccormick opened this issue Mar 9, 2023 · 2 comments

Comments

@kdmccormick
Copy link
Member

NEO4J_AUTH is passed into k8s-managed pods containers as an environment variable: https://github.com/openedx/tutor-contrib-coursegraph/blob/master/tutorcoursegraph/patches/k8s-deployments#L21-L27

This is a not a serious security issue, but it's not great either. Particularly, someone who has permissions to inspect a pod would be able to see the value of NEO4J_AUTH in plaintext.

Instead, the value should be passed into the container as a secret: https://kubernetes.io/docs/concepts/configuration/secret/

@kdmccormick
Copy link
Member Author

@bmtcril , @feanil gave the plugin a look, and this is the one piece of feedback he had.

@bmtcril
Copy link

bmtcril commented Mar 9, 2023

Nice, thanks for pointing that out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants