Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve npm dependency issues in edx-platform #26

Closed
Tracked by #31937
ghassanmas opened this issue Oct 26, 2021 · 6 comments
Closed
Tracked by #31937

Resolve npm dependency issues in edx-platform #26

ghassanmas opened this issue Oct 26, 2021 · 6 comments

Comments

@ghassanmas
Copy link
Member

ghassanmas commented Oct 26, 2021

The edx-platform has conflict in package dependency. This can help to resolve since various process or scripts starts by running npm install in the root of edx-platform which might take time even if node_modules have been already installed. since npm install runs preinstall cycle anyway REF

This issue might not too related to FEWG. however, it might be helpful to post here since it's related to FEWG type of expertise.

1- edx/edx-proctoring

MFE-Platform is edx/[email protected] while edx-proctoring-proctortrack is using edx/[email protected] [REF|https://github.com/anupdhabarde/edx-proctoring-proctortrack/blob/d717f3b7e1d5aec6290d7dd08646cba8c6af3499/package.json#L26].
Note: I am not sure about how edx-proctoring-proctortrack is intended to be installed, the link source returns the master branch here

2- selenium-webdriver

There multiple pacakges in dev depedency that uses the selenium-webdriver, however they conflict with each other, for example, karma-selenium-webdriver-launcher is using [email protected] REF however the platform it self is using [email protected] REF

Other Relevant Links

@ghassanmas ghassanmas changed the title Resolve dependecy issues in frontend-platform Resolve dependecy issues in edx-platform Oct 26, 2021
@mamankhan99 mamankhan99 self-assigned this Jul 6, 2022
@mamankhan99 mamankhan99 removed their assignment Jul 15, 2022
@mamankhan99
Copy link

[email protected] is the latest version that is using [email protected] so an update is not possible here. I believe it isn't breaking anything at the moment and we can eventually exclude these packages from the project when we will break it down into more MFEs till then we can keep it.

@arbrandes
Copy link

@abdullahwaheed, @ishahroz: is this related to the Karma vs Jest conversation we had today? Is there another issue that tracks that?

@abdullahwaheed
Copy link

yes this issue is covered in #105 as well

@kdmccormick
Copy link
Member

kdmccormick commented Feb 27, 2024

Some vague questions:

  1. why is something installing selenium?
  2. why is edx-proctoring or edx-proctoring-proctortrack installing into edx-platform as a node package, given that (I believe) it's been fully replatformed into an MFE?

@feanil
Copy link

feanil commented Jun 14, 2024

The proctoring issue has been resolved here: openedx/edx-platform#34874

@feanil
Copy link

feanil commented Jun 14, 2024

npm install now works cleanly so I'm gonna close this for now.

@feanil feanil closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

No branches or pull requests

8 participants