New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve spacing for the banner #612

Open

msnassar opened this issue Sep 24, 2024 · 0 comments

Contributor

msnassar commented Sep 24, 2024 •

edited

Loading

There are some issues with the banner spacing:

When there is no link added to the banner, the mb-4 on the description (p tag) is adding extra space.
https://github.com/openeuropa/bootstrap-component-library/blob/development/src/compositions/bcl-banner/banner.html.twig#L87
Also the p tag itself has margin.

Proposed resolution:

Remove mb-4 from the description.
Add new css rule to remove margin-bottom from p tag in bcl-banner
Add margin top to link https://github.com/openeuropa/bootstrap-component-library/blob/development/src/compositions/bcl-banner/banner.html.twig#L90

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment