Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the attributes for Open Beauty Facts #3805

Closed
Tracked by #4168
, #4170
...
teolemon opened this issue Feb 4, 2021 · 3 comments
Closed
Tracked by #4168
, #4170
...

Enable the attributes for Open Beauty Facts #3805

teolemon opened this issue Feb 4, 2021 · 3 comments
Labels
attributes good first issue Open Beauty Facts Issues relating to Open Beauty Facts
Milestone
Open Beauty Facts

Comments

@teolemon
Copy link
Member

teolemon commented Feb 4, 2021 •
edited
Loading

What

Enable the attributes for Open Beauty Facts. We have updated the code, and Open Beauty Facts is now attributes capable.

Part of
@teolemon teolemon added the Open Beauty Facts Issues relating to Open Beauty Facts label Feb 5, 2021
@teolemon teolemon linked a pull request Feb 9, 2021 that will close this issue
Attributes for Open Beauty Facts #3825
Closed
@teolemon teolemon added this to the Open Beauty Facts milestone May 8, 2021
This was referenced Aug 22, 2021
Open
Open
@VaiTon
Copy link
Member

VaiTon commented Mar 27, 2022

openfoodfacts-androidapp/app/src/main/java/openfoodfacts/github/scrachx/openfood/features/product/view/ProductViewActivity.kt

Lines 264 to 266 in f17cf09

if (isFlavors(OFF, OBF)) {
adapter += ServerAttributesFragment.newInstance(productState) to activity.getString(R.string.synthesis_tab)
}

@teolemon isn't it already there?

@VaiTon VaiTon closed this as completed Mar 27, 2022
@VaiTon VaiTon reopened this Mar 27, 2022
@teolemon
Copy link
Member Author

Screenshot_20220327-163337.png

@teolemon
Copy link
Member Author

@VaiTon it is, we can indeed close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
attributes good first issue Open Beauty Facts Issues relating to Open Beauty Facts
Projects
None yet
Milestone
Open Beauty Facts
Development

Successfully merging a pull request may close this issue.

Attributes for Open Beauty Facts openfoodfacts/openfoodfacts-androidapp
2 participants
@teolemon @VaiTon