Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add product field "lc" as "product main language" #818

Closed
monsieurtanuki opened this issue Nov 2, 2023 · 1 comment
Closed

Add product field "lc" as "product main language" #818

monsieurtanuki opened this issue Nov 2, 2023 · 1 comment
Labels
✨ enhancement New feature or request 🏄‍♀️ good first issue Good for newcomers

Comments

@monsieurtanuki
Copy link
Contributor

Why - Problem description

lc exists as a product field on the server side.
We don't have it in off-dart.

What - Proposed solution

We should add it to the product fields, probably with a more explicit name like mainLanguage.

Alternatives you've considered

I don't know how important that field is, and it may cause confusion with the product query parameter lc.
Therefore we may not add this field eventually (low interest + average confusion risk).

@monsieurtanuki monsieurtanuki added ✨ enhancement New feature or request 🏄‍♀️ good first issue Good for newcomers labels Nov 2, 2023
@monsieurtanuki
Copy link
Contributor Author

cf. openfoodfacts/smooth-app#4746 (comment)

Not relevant in the end to add lc as a product field.
Just note that lang is a read/write product field that contains the product main language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request 🏄‍♀️ good first issue Good for newcomers
Development

No branches or pull requests

1 participant