Papercuts and features

[teolemon]

Problem

Issues spotted during UX review

Beta Give feedback

1. in export : a pull request can be created the first time but can’t be modified next (user should be able to add a commit)
2. PR created from editor should not be modified via Github directly (add a warning in the PR)
3. Error page : add a warning to tell user to fix them manually via Github (not the editor)
4. Error page : can’t see the entire error (character-limited text area)
5. Existing project : add creation date of a project
6. Allow exporting commits
7. PRs are not generated on the correct repository.
8. Add simple authentication on the Taxonomy Editor to avoid spam.
9. Parsing errors should be actionable.
10. Product Opener does not have a test that detects duplicates in taxonomies
11. When an error is detected during analysis, a solution or resolution method is proposed (even if it is, eg: correct on GitHub, merge, and import the tax again).
12. Indicate on the pull requests generated that they should not be modified from GitHub but directly from the “taxonomy editor” with a link to it or directly a deep link to the project in question on the Taxonomy Editor
13. Add the text in the “Add a new node” button.
14. Add the creation date to the list of projects.
15. Miller columns to view different levels of nodes (and edit a node on the same page) ? or like IDE with toggle lists ?

Technical debt feedback

Beta Give feedback

1. on ne sait pas ce que renvoie l’API Fast API (ajouter des checks ?)
2. UseEffect - hook qui est partout et qui est un anti-pattern
3. Certains fichiers excessivement compliqués
4. Le code du parsing est pas clair, malgré les commentaires
5. Question de la gestion des transactions (trop souvent des transactions)
6. Question des variables globales (anti-pattern ?)
7. Code plus idiomatique. Pas trop de commentaires, plutôt du code idiomatique
8. Travail sur les noms de variables pour les clarifier
9. Pas de linting sur le frontend eslint
10. Typage statique sur le paquet python

For later

Beta Give feedback

1. Add a dark mode to taxonomy-editor