From 0474c591de19600bc048762bee74f9b8d095642e Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Tue, 1 Oct 2024 13:14:09 +1000 Subject: [PATCH 1/2] Fix date-dependent spec --- spec/controllers/spree/credit_cards_controller_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/controllers/spree/credit_cards_controller_spec.rb b/spec/controllers/spree/credit_cards_controller_spec.rb index c5163163ed6..639127676ed 100644 --- a/spec/controllers/spree/credit_cards_controller_spec.rb +++ b/spec/controllers/spree/credit_cards_controller_spec.rb @@ -26,7 +26,7 @@ { format: :json, exp_month: 9, - exp_year: 2024, + exp_year: 1.year.from_now.year, last4: 4242, token: token['id'], cc_type: "visa" From 17c32ae09a9ed41588250798ff25775205af5aaf Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Tue, 1 Oct 2024 13:16:16 +1000 Subject: [PATCH 2/2] Spec change more clearly --- .../spree/credit_cards_controller_spec.rb | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/spec/controllers/spree/credit_cards_controller_spec.rb b/spec/controllers/spree/credit_cards_controller_spec.rb index 639127676ed..f84fd0f7d52 100644 --- a/spec/controllers/spree/credit_cards_controller_spec.rb +++ b/spec/controllers/spree/credit_cards_controller_spec.rb @@ -33,16 +33,13 @@ } end - before do - # there should be no cards stored locally - expect(Spree::CreditCard.count).to eq(0) - end - it "saves the card locally" do - spree_post :new_from_token, params + expect { + spree_post :new_from_token, params + }.to change { + Spree::CreditCard.count + }.from(0).to(1) - # checks whether a card was created - expect(Spree::CreditCard.count).to eq(1) card = Spree::CreditCard.last # retrieves the created card from Stripe