Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rails 7.1 #11673

Open
2 of 4 tasks
Tracked by #12977
mkllnk opened this issue Oct 16, 2023 · 3 comments
Open
2 of 4 tasks
Tracked by #12977

Upgrade to Rails 7.1 #11673

mkllnk opened this issue Oct 16, 2023 · 3 comments

Comments

@mkllnk
Copy link
Member

mkllnk commented Oct 16, 2023

What we should change and why (this is tech debt)

The next Rails version has been released. There are some performance optimisations which would be nice to have and some new tools we can explore. But there are several steps we need to take first:

Context

Impact and timeline

Not critical at the moment. But good to chip away at this issue.

@dacook
Copy link
Member

dacook commented Jan 5, 2025

Just noting that it would be worth waiting until the Ubuntu server upgrades](openfoodfoundation/ofn-install#157) are done, then we can upgrade Node, then Rails.

@mkllnk mkllnk moved this from In Progress ⚙ to Dev ready 👋 in OFN Delivery board Jan 14, 2025
@dacook
Copy link
Member

dacook commented Feb 3, 2025

I just discovered that our current Node version is blocked until we get all servers onto Ubuntu 20 🤦

But the node version doesn't seem to be a blocker for the Rails upgrade. At least, I didn't find any evidence online.
In a previous CI run (#12492), many of the specs succeeded, so I guess the current node version is fine.

@dacook
Copy link
Member

dacook commented Feb 3, 2025

I think all dependencies must be ready for Rails 7.1, because at least some CI runs succeed: https://github.com/dacook/openfoodnetwork/actions/runs/13106684816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Dev ready 👋
Development

Successfully merging a pull request may close this issue.

3 participants