From 4caf53898dbb6711c7634f703fe43100cf346bcd Mon Sep 17 00:00:00 2001 From: ok200lyndon Date: Thu, 15 Aug 2024 06:54:02 +0000 Subject: [PATCH] Lint code --- app/Console/Commands/TestCommand.php | 2 +- .../Api/V1/Admin/ApiAdminAuditItemsController.php | 2 +- app/Models/AuditItem.php | 3 +-- .../2024_08_14_052516_create_audit_items_table.php | 2 +- tests/Feature/API/App/AuditItems/AuditItemsDeleteTest.php | 1 - tests/Unit/Models/UserTest.php | 6 +++--- 6 files changed, 7 insertions(+), 9 deletions(-) diff --git a/app/Console/Commands/TestCommand.php b/app/Console/Commands/TestCommand.php index c9f7e1ed..35b8e1c8 100644 --- a/app/Console/Commands/TestCommand.php +++ b/app/Console/Commands/TestCommand.php @@ -35,7 +35,7 @@ public function handle() $vouchers = Voucher::factory(100)->createQuietly(); $voucherSets = VoucherSet::factory(100)->createQuietly(); $auditItems = AuditItem::factory(100)->createQuietly([ - 'team_id' => 1 + 'team_id' => 1, ]); } } diff --git a/app/Http/Controllers/Api/V1/Admin/ApiAdminAuditItemsController.php b/app/Http/Controllers/Api/V1/Admin/ApiAdminAuditItemsController.php index ee61a334..1f50cdfc 100644 --- a/app/Http/Controllers/Api/V1/Admin/ApiAdminAuditItemsController.php +++ b/app/Http/Controllers/Api/V1/Admin/ApiAdminAuditItemsController.php @@ -17,7 +17,7 @@ class ApiAdminAuditItemsController extends Controller * Set the related data the GET request is allowed to ask for */ public array $availableRelations = [ - 'team' + 'team', ]; public static array $searchableFields = []; diff --git a/app/Models/AuditItem.php b/app/Models/AuditItem.php index 8dd81083..5c92d289 100644 --- a/app/Models/AuditItem.php +++ b/app/Models/AuditItem.php @@ -5,7 +5,6 @@ use Illuminate\Database\Eloquent\Factories\HasFactory; use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Eloquent\Relations\BelongsTo; -use Illuminate\Database\Eloquent\Relations\HasOne; use Illuminate\Database\Eloquent\Relations\MorphTo; class AuditItem extends Model @@ -19,6 +18,6 @@ public function auditable(): MorphTo public function team(): BelongsTo { - return $this->belongsTo( Team::class, 'team_id', 'id'); + return $this->belongsTo(Team::class, 'team_id', 'id'); } } diff --git a/database/migrations/2024_08_14_052516_create_audit_items_table.php b/database/migrations/2024_08_14_052516_create_audit_items_table.php index 78d7346d..7b5d9fed 100644 --- a/database/migrations/2024_08_14_052516_create_audit_items_table.php +++ b/database/migrations/2024_08_14_052516_create_audit_items_table.php @@ -4,7 +4,7 @@ use Illuminate\Database\Schema\Blueprint; use Illuminate\Support\Facades\Schema; -return new class extends Migration +return new class() extends Migration { /** * Run the migrations. diff --git a/tests/Feature/API/App/AuditItems/AuditItemsDeleteTest.php b/tests/Feature/API/App/AuditItems/AuditItemsDeleteTest.php index 18bda17a..f1bbadbd 100644 --- a/tests/Feature/API/App/AuditItems/AuditItemsDeleteTest.php +++ b/tests/Feature/API/App/AuditItems/AuditItemsDeleteTest.php @@ -5,7 +5,6 @@ use App\Enums\ApiResponse; use App\Enums\PersonalAccessTokenAbility; use App\Models\AuditItem; -use App\Models\User; use Illuminate\Foundation\Testing\DatabaseTransactions; use Illuminate\Foundation\Testing\WithFaker; use Laravel\Sanctum\Sanctum; diff --git a/tests/Unit/Models/UserTest.php b/tests/Unit/Models/UserTest.php index 33989b32..f972405b 100644 --- a/tests/Unit/Models/UserTest.php +++ b/tests/Unit/Models/UserTest.php @@ -40,19 +40,19 @@ public function testAuditItemsRelation(): void AuditItem::factory($num)->create([ 'auditable_type' => User::class, - 'auditable_id' => $user->id, + 'auditable_id' => $user->id, ]); // Same ID but different class, should NOT be returned AuditItem::factory($num)->create([ 'auditable_type' => Team::class, - 'auditable_id' => $user->id, + 'auditable_id' => $user->id, ]); // Same class but different ID, should NOT be returned AuditItem::factory($num)->create([ 'auditable_type' => User::class, - 'auditable_id' => $user->id + 1, + 'auditable_id' => $user->id + 1, ]); $userWithAuditItems = User::with('auditItems')->find($user->id);