Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace node-jose with jose #328

Open
LoneRifle opened this issue Jan 20, 2022 · 2 comments
Open

Replace node-jose with jose #328

LoneRifle opened this issue Jan 20, 2022 · 2 comments

Comments

@LoneRifle
Copy link
Collaborator

Given that Node.js has an intrinsic module to handle cryptography, we should drop node-jose in favour of that.
@snyk-bot snyk-bot mentioned this issue Feb 11, 2022
Open
@LoneRifle LoneRifle changed the title Replace node-jose with crypto Replace node-jose with jose May 20, 2022
amandalim857 added a commit to amandalim857/mockpass that referenced this issue Jul 12, 2023
@amandalim857
refactor(myinfo): replace use of node-jose with jose library for myin…
d461696 
…fo SSO (opengovsg#328)
amandalim857 added a commit to amandalim857/mockpass that referenced this issue Jul 12, 2023
@amandalim857
refactor(myinfo): replace node-jose with jose for SSO (opengovsg#328)
2a37a0a
amandalim857 added a commit to amandalim857/mockpass that referenced this issue Jul 12, 2023
@amandalim857
refactor(myinfo): replace node-jose with jose for SSO (opengovsg#328)
20c20ba
amandalim857 added a commit to amandalim857/mockpass that referenced this issue Jul 12, 2023
@amandalim857
refactor(myinfo): replace node-jose with jose for SSO (opengovsg#328)
5efd27a
@amandalim857 amandalim857 mentioned this issue Jul 12, 2023
Merged
@fliodhais
Copy link

should probably mark this as closed then?

@LoneRifle
Copy link
Collaborator Author

should probably mark this as closed then?

It's not been completely replaced. Feel free to submit further PRs to close the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LoneRifle @fliodhais