Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Code Coverage Hole in cv32e40p_controller module lines 632 and 642 #1006

Open
pascalgouedo opened this issue Jun 18, 2024 · 0 comments
Open
Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory) WAIVED:CV32E40P Issue does not impact a major release of CV32E40P and is waived

Comments

@pascalgouedo
Copy link

Component

Component:RTL

Issue description

There are 2 branches not covered on line 632 and 642 of cv32e40p_controller during all the simulation non-regressions.

After a lot of talks and brainstorming, it was suspected that those AllFalse uncovered branches could be unreachable cases.
SLEC app of Cadence JasperGold was used to prove that there is no difference on CV32E40P top level output signals between original RTL code and a modified one where lines 632, 638, 642 and 648 are totally removed.
As the tool is not able to generate a scenario/counter-example by driving any kind of sequential sequence on CV32E40P top level input signals showing a different behavior on output signals between the original RTL and the modified one, the conclusion is that AllFalse uncovered branches are really unreachable.

To reproduce/analyze it, slec run could be launched between original RTL code and a modified one by going in cv32e40p/scripts/slec and by launching following command:
./run.sh -t cadence -p sec

As it was too late to remove those lines in the RTL due to long RISC-V ISA Formal Verification runs and requiring to update all waivers files as well, it has been decided to waive those 2 branches holes in v2.

632_642-1

632

642

@pascalgouedo pascalgouedo added Component:RTL For issues in the RTL (e.g. for files in the rtl directory) WAIVED:CV32E40P Issue does not impact a major release of CV32E40P and is waived labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory) WAIVED:CV32E40P Issue does not impact a major release of CV32E40P and is waived
Projects
None yet
Development

No branches or pull requests

1 participant