From f042d77f844e70a48db0a006e3c8a5aa8a75d85b Mon Sep 17 00:00:00 2001 From: Ludvig Janiuk Date: Tue, 21 Jan 2025 14:19:29 +0000 Subject: [PATCH 1/2] 7903935 --verify-exclude existence check misses tests with failing requires --- .../classes/com/sun/javatest/regtest/tool/Tool.java | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/share/classes/com/sun/javatest/regtest/tool/Tool.java b/src/share/classes/com/sun/javatest/regtest/tool/Tool.java index 6eb134de..346f1b38 100644 --- a/src/share/classes/com/sun/javatest/regtest/tool/Tool.java +++ b/src/share/classes/com/sun/javatest/regtest/tool/Tool.java @@ -1439,7 +1439,7 @@ void verifyExcludeLists(TestManager testManager, Path baseDir) throws BadArgs, F } RegressionParameters params = createParameters(dummyTestManager, ts); - for (Iterator iter = getResultsIterator(params); iter.hasNext(); ) { + for (Iterator iter = getEagerResultsIterator(params); iter.hasNext(); ) { TestResult tr = iter.next(); validTestNames.add(tr.getTestName()); if (verbose == Verbose.ALL) { @@ -2208,6 +2208,14 @@ else if (tests.length == 0) return trt.getIterator(tests, filters); } + // Trying to get all possible results + private Iterator getEagerResultsIterator(InterviewParameters params) { + TestResultTable trt = params.getWorkDirectory().getTestResultTable(); + trt.waitUntilReady(); + TestFilter[] filters = null; + return trt.getIterator(filters); + } + private void showTool(final InterviewParameters params) throws BadArgs { EventQueue.invokeLater(new Runnable() { @Override From 3131c353973afd5f2850b3fbf50ca3a144f7c0ca Mon Sep 17 00:00:00 2001 From: Ludvig Janiuk Date: Mon, 27 Jan 2025 09:56:41 +0000 Subject: [PATCH 2/2] Update comment --- src/share/classes/com/sun/javatest/regtest/tool/Tool.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/share/classes/com/sun/javatest/regtest/tool/Tool.java b/src/share/classes/com/sun/javatest/regtest/tool/Tool.java index 346f1b38..8c73e582 100644 --- a/src/share/classes/com/sun/javatest/regtest/tool/Tool.java +++ b/src/share/classes/com/sun/javatest/regtest/tool/Tool.java @@ -2208,7 +2208,8 @@ else if (tests.length == 0) return trt.getIterator(tests, filters); } - // Trying to get all possible results + // An iterator that applies no filters. + // The intention is to help discover all "existing" tests. private Iterator getEagerResultsIterator(InterviewParameters params) { TestResultTable trt = params.getWorkDirectory().getTestResultTable(); trt.waitUntilReady();