-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: A course on the setup, running, and analysis of biomolecular simulations #265
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
Hi @raquellrios, @djcole56 anything I could help with to get you started with the review? |
Review checklist for @djcole56Conflict of interest
Code of Conduct
General checks
Documentation
Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)
JOSE paper
|
Hi, I'll drop any issues with the notebooks in here as I'm going along. In 4_Simulation_Setup, only this method works:
ie reading from file does not (I guess because it's not a mapped smiles). More generally, it would be good to include instruction for how to make a mapped smiles if this is necessary input. |
@ppxasjsm @degiacom Finished going through the material. The course comprises a series of around 8 lectures and 8 workshops, with the first half devoted to setting up and running biomolecular simulations, and the second half to data analysis, including introductions to machine learning. The lectures are very clear and could be adopted by other teachers for their own courses. The workshops are presented through Jupyter notebooks, and I followed them on Google colab (as I imagine most students would). These are again very clearly presented and at a suitable level for a graduate or advanced undergrad class. Worked examples and problems are used throughout to hold attention, and the material usually progresses nicely from toy models to realistic simulation data. This course is commended for focusing on the fundamentals of simulation and analysis that is mostly agnostic to the underlying MD codes, and doesn't require any expensive licenses. The material has clearly been used for teaching on several occasions, so I only found the one issue (above). Also nglview is not always able to run the trajectories on colab, but I this is a recurring problem, and not the authors' issue (it might still be worth warning students that they can use their favourite pdb viewer if this happens). If I understand the journal requirements correctly, the GitHub page needs a 'statement of need' and 'community guidelines', then I'm happy to sign it off. |
The statement of need is typically for the paper not the GitHub repo. |
Review checklist for @raquellriosConflict of interest
Code of Conduct
General checks
Documentation
Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)
JOSE paper
|
I am linking here my comments for the first part: |
I am linking here my comments for the second part: |
Review: The course "Molecular Dynamics Simulation and Analysis Workshop", developed by @ppxasjsm and @degiacom covers the theoretical foundations of MD simulations of protein systems and their analysis, including advanced analysis topics, such as dimensionality reduction and supervised machine learning (ML) classifications. The course targets graduate students with a basic understanding of MD simulations and Python. The course is divided into two units:
Each lecture includes a PDF document with slides. I found the content in all lectures clear and easy to follow, enhanced by numerous visual aids that will help students understand complex topics. Such visual representations will be of great help for students following this material individually. Furthermore, the analysis lectures (Unit 2) provide examples that demonstrate the practical application of the described methods (PCA, Random forests, etc.) to molecular simulations. In addition to the slides, the course offers practical sessions (except for Lecture 1, which serves as an introduction to proteins). Most of these sessions are presented as Jupyter Notebooks that run seamlessly on Google Colab. These notebooks are well-structured with clear code explanations. Furthermore, practicals include questions to students. These questions will foster active learning, preventing students from just pressing "run" on every cell without thinking about what they are doing. The inclusion of solutions to these questions ensures that students can complete the exercises independently. The use of Colab eliminates the need for students to download software or have access to high-performance computing resources, significantly improving the usability and accessibility of the course. Also, a key strength of the course is its exclusive reliance on open-source software, aligning with the principles of open science and ensuring accessibility for all students. Furthermore, the course is able to go from an introduction to proteins to ML, addressing both fundamental and cutting-edge topics like AlphaFold and supervised classification. I believe Lectures 6–8 are particularly noteworthy, as they cover advanced topics for which there are not that many well established learning resources (compared to docking or MD simulations) that cover these topics in such a clear way. Also, the modular design of the material will allow teachers to adopt individual lectures or practical sessions independently, except for Practical 8, which builds upon Practical 7. This flexibility increases the course's applicability across different educational settings. Overall I only have a few comments on the material, which I have reported as Issues in the target repository. Some of these comments are classified as "optional", which means that I do not think they are absolutely necessary but would improve explainability. Regarding the JOSE checklist, I do not see "community guidelines" in the documentation, but I assume this is a self-contained module so it may not need them. This course provides a robust, well-designed learning process that spans foundational to advanced topics in MD simulations. Its focus on modern methods makes it a valuable resource for students and teachers. I highly recommend this material for publication after addressing the submitted comments. |
Okay, it looks like @raquellrios is happy. However, @degiacom and @ppxasjsm please let me know when you have addressed their issues. And when @djcole56's comment about the Statement of Need has been addressed. |
Hi @djcole56,
I cannot recreate your issues. Maybe you could try again? I have also added a link to more explantions in an other resource on how to read in molcules. Please take a look a this commit to see if everything has been adequately addressed: CCPBioSim/BioSim-analysis-workshop@cd8c7f7 |
Hi @raquellrios and @djcole56 thank you so much for your nice comments and thoughtful reviews. We have not added a statement of need to the Github as it is covered in the paper. We have added some community guidelines in this commit: CCPBioSim/BioSim-analysis-workshop@d381349. I believe we have now addressed all the concerns raised by issues on the repo and in this thread. If you agree, then we hope that @arm61 can proceed with the submission. Have a lovely holiday break, everyone! |
@arm61 all good to go from my side. |
Same here! Everything looks great! |
@editorialbot generate pdf |
@editorialbot check references |
|
Hello @arm61, thank you for having had a look at our paper. Perhaps, we could leave the Colab badges in the repo's README file, but replace them with a text ("Open in Colab") with hyperlink in the paper? |
Yeah, I think that would look better (small things 😄). |
Done! I replaced the "Open in Colab" badges with a "Notebook" plain text. |
@editorialbot generate pdf |
Great, the next step is for you to proof read it and ensure there are no typos, etc. Let me know when you are happy with the text. |
We have now checked grammar/orthograph of the paper, we are happy with it! |
Submitting author: @degiacom (Matteo Degiacomi)
Repository: https://github.com/CCPBioSim/BioSim-analysis-workshop
Branch with paper.md (empty if default branch):
Version: v1.0
Editor: @arm61
Reviewers: @raquellrios, @djcole56
Archive: Pending
Paper kind: learning module
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@raquellrios & @djcole56, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://openjournals.readthedocs.io/en/jose/reviewer_guidelines.html. Any questions/concerns please let @arm61 know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @raquellrios
📝 Checklist for @djcole56
The text was updated successfully, but these errors were encountered: