Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect attachment names in JATS #5718

Open
sneakers-the-rat opened this issue Aug 3, 2024 · 0 comments
Open

Incorrect attachment names in JATS #5718

sneakers-the-rat opened this issue Aug 3, 2024 · 0 comments

Comments

@sneakers-the-rat
Copy link

sneakers-the-rat commented Aug 3, 2024

06802

Attachments have content hash names, but JATS refers to them with relative paths that don't exist like ../assets/figure/etc.png

05744

has two .jats files - the one in paper.jats refers to media files in the current directory, but they don't exist. they are in the media directory - https://github.com/openjournals/joss-papers/blob/master/joss.05744/paper.jats/10.21105.joss.05744.jats


Full list

Here are all the jats files that refer to files that don't exist where they are supposed to be. Most of these are fairly recent, so it suggests that something is wrong with the new nested style of jats.paper directory style generation. i don't know for sure but it looks like 03860's pdfs were before we handled pdfs properly?

generated with https://github.com/sneakers-the-rat/joss-migrate-pmc/blob/31ef3ace00a8b4dd96622ca89510118b0215a242/src/joss_migrate_pmc/checks.py#L29

jats missing
0 joss-6-03860/10.21105.joss.03860.jats media/flowtorch_components_plain.pdf
1 joss-6-03860/10.21105.joss.03860.jats media/dmd_modes_airfoil_cp.pdf
2 joss-6-03860/10.21105.joss.03860.jats media/cnm_cluster_transition.pdf
3 joss-9-06711/10.21105.joss.06711.jats ./images/RoughnessExample.png
4 joss-7-04622/10.21105.joss.04622.jats media/figures/software_illustration.png
5 joss-7-04622/10.21105.joss.04622.jats media/figures/code_snippet.png
6 joss-9-06598/10.21105.joss.06598.jats ./../docs/images/BitPackingTable.png?raw=true
7 joss-9-06598/10.21105.joss.06598.jats ./../docs/images/ExampleEncoding.png?raw=true
8 joss-9-06802/10.21105.joss.06802.jats ../assets/images/overview_2.png
9 joss-9-06802/10.21105.joss.06802.jats ../assets/images/pipelines.png
10 joss-9-06802/10.21105.joss.06802.jats ../assets/images/augmentation_pipeline.svg
11 joss-9-06802/10.21105.joss.06802.jats ../assets/images/applications.png
12 joss-9-05756/10.21105.joss.05756.jats media/Figure%201.png
13 joss-9-05756/10.21105.joss.05756.jats media/Figure%202.png
14 joss-8-05403/10.21105.joss.05403.jats media/graphics/espnet-SE%2B%2B.png
15 joss-9-06930/10.21105.joss.06930.jats https://github.com/mnets/pymnet/blob/publication/paper/figs/l2_n3.png?raw=true
16 joss-9-06930/10.21105.joss.06930.jats https://github.com/mnets/pymnet/blob/publication/paper/figs/cites-trades_commercial_live-meat.png?raw=true
17 joss-9-05854/10.21105.joss.05854.jats media/physiolabxr%20teaser.png
18 joss-9-05854/10.21105.joss.05854.jats media/scripting%20example.png
19 joss-9-05854/10.21105.joss.05854.jats media/PhysioLabXR%20Sequence%20Diagram.png
20 joss-9-06645/10.21105.joss.06645.jats ../graphdb-visual.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant