Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Miet: an R package for region of interest analysis from magnetic reasonance images #1842

Closed
whedon opened this issue Oct 29, 2019 · 39 comments

Comments

@whedon
Copy link

whedon commented Oct 29, 2019

Submitting author: @benoit-combes (Benoit Combès)
Repository: https://gitlab.inria.fr/miet/miet
Version: 0.1.0
Editor: @arokem
Reviewers: @janfreyberg, @neuroimaginador

Author instructions

Thanks for submitting your paper to JOSS @benoit-combes. Currently, there isn't an JOSS editor assigned to your paper.

@benoit-combes if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Oct 29, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Oct 29, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Oct 29, 2019

PDF failed to compile for issue #1842 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/1842 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in collect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/lib/whedon/processor.rb:61:in find_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@danielskatz
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 29, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Oct 29, 2019

PDF failed to compile for issue #1842 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/1842 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in collect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/lib/whedon/processor.rb:61:in find_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@danielskatz
Copy link

👋 @arfon - I'm a bit confused about what the error is here - is this related to the figure? Perhaps you can help? (and maybe open a whedon issue related to better error message?)

@arfon
Copy link
Member

arfon commented Oct 29, 2019

@danielskatz - I think this is because the URL at the top can't be cloned by Git. It needs changing to https://gitlab.inria.fr/miet/miet

@danielskatz
Copy link

👋 @benoit-combes - Please change the paper.md as @arfon suggests, then enter a new comment here with @whedon generate pdf to try recompiling

@arfon
Copy link
Member

arfon commented Oct 29, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 29, 2019

Attempting PDF compilation. Reticulating splines etc...

@arfon
Copy link
Member

arfon commented Oct 29, 2019

@danielskatz - just to clarify, the URL for the repo needed editing at the top of the issue (I've done this).

@whedon
Copy link
Author

whedon commented Oct 29, 2019

@danielskatz
Copy link

ah, sorry, I thought you meant in the paper.md - How did this wrong URL get in? User error in the submission form?

@arfon
Copy link
Member

arfon commented Oct 29, 2019

ah, sorry, I thought you meant in the paper.md - How did this wrong URL get in? User error in the submission form?

Yeah, it was an error in the submission form. I've opened an issue to track this (openjournals/whedon#60)

@benoit-combes
Copy link

benoit-combes commented Oct 29, 2019

May I suggest @neuroimaginador that appears to gather expertise in R, data analysis and neuroimaging (that are relevant for the paper) for reviewing ?

@benoit-combes
Copy link

@whedon commands

@whedon
Copy link
Author

whedon commented Oct 29, 2019

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

@benoit-combes
Copy link

@whedon list editors

@whedon
Copy link
Author

whedon commented Oct 31, 2019

Current editors:

@Kevin-Mattheus-Moerman
@VivianePons
@alexhanna
@arfon
@arokem
@brainstorm
@cMadan
@csoneson
@danielskatz
@dfm
@drvinceknight
@gkthiruvathukal
@jedbrown
@karthik
@katyhuff
@kbarnhart
@kthyng
@kyleniemeyer
@labarba
@leouieda
@lheagy
@lpantano
@majensen
@mbobra
@meg-simula
@melissawm
@mgymrek
@mjsottile
@oliviaguest
@poulson
@terrytangyuan
@trallard
@usethedata
@will-rowe
@xuanxu

@benoit-combes
Copy link

May I suggest @arokem as editor ?
In addition to @neuroimaginador that appears to gather expertise in R, data analysis and neuroimaging (that are relevant for the paper) for reviewer ?

@arokem
Copy link

arokem commented Oct 31, 2019

Yes. I can edit this.

@arokem
Copy link

arokem commented Oct 31, 2019

@whedon assign arokem as editor

@whedon
Copy link
Author

whedon commented Oct 31, 2019

OK, the editor is arokem

@arokem
Copy link

arokem commented Oct 31, 2019

👋 @neuroimaginador : would you be willing to review this paper for JOSS?

@arfon
Copy link
Member

arfon commented Oct 31, 2019

@arokem @brechmos (who's here at STScI) might be a good additional reviewer.

@arokem
Copy link

arokem commented Oct 31, 2019 via email

@arokem
Copy link

arokem commented Oct 31, 2019

👋 @janfreyberg : would you be willing to review this paper for JOSS? You are one of the only people among our reviewer pool who are neuro-savvy and also R-literate, so it would be a great help.

@janfreyberg
Copy link

@arokem yes, of course!

@arokem
Copy link

arokem commented Oct 31, 2019

Wonderful. Thank you! I will assign you first, and then stand by until I find another reviewer and kick off the review for this.

@arokem
Copy link

arokem commented Oct 31, 2019

@whedon assign @janfreyberg as reviewer

@whedon whedon assigned arokem and janfreyberg and unassigned arokem Oct 31, 2019
@whedon
Copy link
Author

whedon commented Oct 31, 2019

OK, the reviewer is @janfreyberg

@neuroimaginador
Copy link

neuroimaginador commented Nov 2, 2019 via email

@arokem
Copy link

arokem commented Nov 2, 2019

Thanks @neuroimaginador ! You are on!

@arokem
Copy link

arokem commented Nov 2, 2019

@whedon add @neuroimaginador as reviewer

@whedon
Copy link
Author

whedon commented Nov 2, 2019

OK, @neuroimaginador is now a reviewer

@arokem
Copy link

arokem commented Nov 2, 2019

@whedon start review

@whedon
Copy link
Author

whedon commented Nov 2, 2019

OK, I've started the review over in #1862. Feel free to close this issue now!

@arokem
Copy link

arokem commented Nov 2, 2019

Alright, @janfreyberg and @neuroimaginador, please head over to #1862 for your reviewer check-lists. Feel free to tag me into issues, if you have any questions, as you work through this. I'll close this now. Thanks again!

@arokem arokem closed this as completed Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants