[PRE REVIEW]: EXP: a Python/C++ package for basis function expansion methods in galactic dynamics

[editorialbot]

Submitting author: @michael-petersen (Michael Petersen)
Repository: https://github.com/EXP-code/EXP
Branch with paper.md (empty if default branch):
Version: v7.7.99
Editor: @dfm
Reviewers: @schuhmaj
Managing EiC: Dan Foreman-Mackey

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/869a8ce345b8756b1235b1b32986794f"><img src="https://joss.theoj.org/papers/869a8ce345b8756b1235b1b32986794f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/869a8ce345b8756b1235b1b32986794f/status.svg)](https://joss.theoj.org/papers/869a8ce345b8756b1235b1b32986794f)

Author instructions

Thanks for submitting your paper to JOSS @michael-petersen. Currently, there isn't a JOSS editor assigned to your paper.

@michael-petersen if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.51 s (1358.4 files/s, 441007.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                            346          28411          15821         103122
C/C++ Header                   259           9103           9830          24861
CUDA                            15           2467           1802           8525
Fortran 77                       3             22           1646           4173
C                               21            736           1526           4073
CSS                              4            466            196           2964
XML                              3              5              7           1593
CMake                           19            308            200           1319
TeX                              2             95             16            810
HTML                             4             53             16            730
Markdown                         9            187              0            723
Python                           8            204            252            434
YAML                             3             21             58            120
Bourne Shell                     1              3              0             10
C Shell                          1              6              4              7
JSON                             1              0              0              7
-------------------------------------------------------------------------------
SUM:                           699          42087          31374         153471
-------------------------------------------------------------------------------

Commit count by author:

  4664	Martin D. Weinberg
   937	weinberg
   223	mdw
    66	Martin Weinberg
    40	michael-petersen
    28	michael_petersen
    20	jhchoi
    16	Adrian Price-Whelan
    11	Robert Blackwell
    10	r-j-arnold
     2	Becky Arnold
     1	(no author)
     1	Martin Weinberg [[email protected]]
     1	Michael
     1	arora125

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1051/0004-6361/201629272 is OK
- 10.1051/0004-6361/201832865 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.21105/joss.00388 is OK
- 10.1093/mnras/stad2591 is OK
- 10.1093/mnras/staa3997 is OK
- 10.1093/mnras/stab3639 is OK
- 10.1093/mnras/stad485 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1086/300669 is OK
- 10.1109/MCSE.2007.53 is OK
- 10.3233/978-1-61499-649-1-87 is OK
- 10.3847/1538-4357/ac0b44 is OK
- 10.1086/168845 is OK
- 10.1086/171025 is OK
- 10.1086/304888 is OK

MISSING DOIs

- No DOI given, and none found for title: Galactic Dynamics: Second Edition
- No DOI given, and none found for title: Hierarchical data format version 5
- No DOI given, and none found for title: pybind11 – Seamless operability between C++11 and ...
- 10.1198/004017002320256477 may be a valid DOI for title: Analysis of time series structure: SSA and related...
- No DOI given, and none found for title: Eigen v3
- No DOI given, and none found for title: CUDA, release: 10.2.89
- No DOI given, and none found for title: MPI: A Message-Passing Interface Standard Version ...

INVALID DOIs

- None

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 1504

✅ The paper includes a Statement of need section

[editorialbot]

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

[dfm]

@michael-petersen — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[editorialbot]

Five most similar historical JOSS papers:

Efficient Polyhedral Gravity Modeling in Modern C++ and Python
Submitting author: @schuhmaj
Handling editor: @dfm (Active)
Reviewers: @mikegrudic, @santisoler
Similarity score: 0.7400

Swiftest: An \textit{N}-body Integrator for Gravitational Systems
Submitting author: @carlislewishard
Handling editor: @warrickball (Active)
Reviewers: @hannorein, @mikegrudic, @aatrani
Similarity score: 0.7384

pytreegrav: A fast Python gravity solver
Submitting author: @mikegrudic
Handling editor: @dfm (Active)
Reviewers: @adrn, @maxwelltsai
Similarity score: 0.7313

21cmFAST v3: A Python-integrated C code for generating 3D realizations of the cosmic 21cm signal.
Submitting author: @steven-murray
Handling editor: @dfm (Active)
Reviewers: @sambit-giri, @sultan-hassan
Similarity score: 0.7283

Triumvirate: A Python/C++ package for three-point clustering measurements
Submitting author: @MikeSWang
Handling editor: @ivastar (Active)
Reviewers: @alfonso-veropalumbo, @wcoulton
Similarity score: 0.7252

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[dfm]

@editorialbot assign me as editor

@michael-petersen — Thanks for your patience! This summer has been slow for JOSS turnarounds, but we're starting to catch up. I'll take your submission on as editor and start looking for reviewers early next week. Please feel free to share any recommendations for reviewers from your networks or our database in the meantime.

[editorialbot]

Assigned! @dfm is now the editor

[dfm]

👋 @mikegrudic, @schuhmaj, @jobovy, @maxwelltsai — would any of you be willing to review this submission for The Journal of Open Source Software? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

[schuhmaj]

@dfm Hi, I would be available to review 👍

[dfm]

@editorialbot add @schuhmaj as reviewer

Thanks for the positive response @schuhmaj! As soon as we get a second reviewer we'll get the main review thread started.

@michael-petersen — if you have any suggestions for folks who might be good reviewers please feel free to recommend here. Thanks!

[editorialbot]

@schuhmaj added to the reviewers list!

[dfm]

@editorialbot start review

Thanks all for your patience! I haven't been able to find a second reviewer yet, but let's open the review thread so that @schuhmaj can get started, and I'll keep looking in the meantime. See you over in the review thread!

[editorialbot]

OK, I've started the review over in #7302.