Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: CycloPhaser: A Python Package for Detecting Extratropical Cyclone Life Cycles #7280

Open
editorialbot opened this issue Sep 25, 2024 · 13 comments
Labels

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @daniloceano (Danilo Couto de Souza)
Repository: https://github.com/daniloceano/CycloPhaser
Branch with paper.md (empty if default branch): joss-submission
Version: 1.8.1
Editor: Pending
Reviewers: Pending
Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/fc6ccda843aaedbf2d813473b7a561e0"><img src="https://joss.theoj.org/papers/fc6ccda843aaedbf2d813473b7a561e0/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/fc6ccda843aaedbf2d813473b7a561e0/status.svg)](https://joss.theoj.org/papers/fc6ccda843aaedbf2d813473b7a561e0)

Author instructions

Thanks for submitting your paper to JOSS @daniloceano. Currently, there isn't a JOSS editor assigned to your paper.

@daniloceano if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 6 (ESE) Earth Sciences and Ecology labels Sep 25, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (1223.3 files/s, 122553.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          10            322            268            991
Markdown                         3            124              0            197
TeX                              1             19              0            154
reStructuredText                 7             95             84            143
YAML                             3             32             13            142
CSV                              1              0              0             66
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            27            604            373           1728
-------------------------------------------------------------------------------

Commit count by author:

    59	daniloceano
    18	Danilo Couto de Souza

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1063

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- None

🟡 SKIP DOIs

- No DOI given, and none found for title: Life cycle of cyclones and the polar front theory ...
- No DOI given, and none found for title: SciPy 1.0: fundamental algorithms for scientific c...

❌ MISSING DOIs

- 10.1007/978-1-944970-33-8_10 may be a valid DOI for title: Fronts, jet streams and the tropopause
- 10.1175/1520-0493(1993)121<2153:tlcoae>2.0.co;2 may be a valid DOI for title: The life cycle of an extratropical marine cyclone....
- 10.1175/bams-d-16-0261.1 may be a valid DOI for title: When during their life cycle are extratropical cyc...
- 10.1175/mwr3420.1 may be a valid DOI for title: Climatology of cyclone size characteristics and th...
- 10.1175/2008mwr2491.1 may be a valid DOI for title: The spatial distribution and evolution characteris...
- 10.1175/jas-d-13-0267.1 may be a valid DOI for title: The vorticity budgets of North Atlantic winter ext...
- 10.1029/2018gl078977 may be a valid DOI for title: Extratropical cyclone precipitation life cycles: A...
- 10.1029/2018gl078977 may be a valid DOI for title: Extratropical cyclone precipitation life cycles: A...
- 10.1175/jcli-d-16-0697.1 may be a valid DOI for title: Changes in winter North Atlantic extratropical cyc...
- 10.1002/joc.8539 may be a valid DOI for title: New perspectives on South Atlantic storm track thr...
- 10.1007/s00382-019-04778-1 may be a valid DOI for title: The properties and genesis environments of South A...
- 10.21203/rs.3.rs-995499/v1 may be a valid DOI for title: Impact of extratropical cyclone intensity and spee...
- 10.1029/2022ea002482 may be a valid DOI for title: Synoptic Climatology of Subtropical Cyclone Impact...
- 10.3354/cr01651 may be a valid DOI for title: Ocean-Land Atmosphere Model (OLAM) performance for...
- 10.1007/s11069-024-06621-1 may be a valid DOI for title: Extreme rainfall and landslides as a response to h...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

StormR: An R package to quantify and map the tropical storms and cyclones’ winds characteristics
Submitting author: @thomasarsouze
Handling editor: @hugoledoux (Active)
Reviewers: @gsapijaszko, @highamm
Similarity score: 0.6952

sandpyper: A Python package for UAV-SfM beach volumetric and behavioural analysis
Submitting author: @npucino
Handling editor: @crvernon (Active)
Reviewers: @dbuscombe-usgs, @chrisleaman
Similarity score: 0.6754

xeofs: Comprehensive EOF analysis in Python with xarray
Submitting author: @nicrie
Handling editor: @samhforbes (Active)
Reviewers: @DamienIrving, @malmans2
Similarity score: 0.6743

IPART: A Python Package for Image-Processing based Atmospheric River Tracking
Submitting author: @Xunius
Handling editor: @kbarnhart (Retired)
Reviewers: @sadielbartholomew, @rabernat
Similarity score: 0.6699

qgs: A flexible Python framework of reduced-order multiscale climate models
Submitting author: @jodemaey
Handling editor: @harpolea (Retired)
Reviewers: @eviatarbach, @sadielbartholomew
Similarity score: 0.6660

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kthyng
Copy link

kthyng commented Sep 25, 2024

Welcome back @daniloceano and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them.

@daniloceano
Copy link

Hello @kthyng,

Regarding the list of MISSING DOIs, I am a bit confused as the DOIs were provided and direct to the correct papers. Could you please clarify what needs to be done in this case?

As for the reviewers, I would like to suggest the following:

Mattia Almansi
koldunovn
Harald von Waldow
Einara Zahn
amylu00

Best regards,

Danilo

@kthyng
Copy link

kthyng commented Sep 26, 2024

@daniloceano The note about DOIs is requesting they be present in your .bib file so they come through the references list. I don't see any DOIs in there: https://github.com/daniloceano/CycloPhaser/blob/joss-submission/paper/paper.bib.

@kthyng
Copy link

kthyng commented Sep 26, 2024

@daniloceano comments:

  • I see you have docs that say notes about your software. Do you show what it does somewhere? For example, you process vorticity data: https://cyclophaser.readthedocs.io/en/latest/usage.html#example-processing-vorticity-data-from-era5 but it's hard to understand what exactly your software does without some pictures to support it. Would you consider adding this?
  • You have two summaries in your paper
  • the in line references have parentheses
  • Can the package be used in the northern hemisphere now or just in theory?

@daniloceano
Copy link

@kthyng

Thank you for the feedback.

  • I have updated the documentation to provide more clarity on what the software does. There is now an Overview section explaining the main purpose of CycloPhaser and a concise description of how it detects cyclone life cycle phases. Additionally, I have added a figure illustrating the CycloPhaser methodology, which visually supports the process of detecting the life cycle stages of cyclones, offering a clearer understanding of the software's capabilities.
  • I have deleted the extra summary (oops!)
  • I have fixed the inline references and addressed the missing DOIs in the .bib file.
  • Regarding Northern Hemisphere support: Yes, CycloPhaser can be used for the Northern Hemisphere as long as the original vorticity series is multiplied by -1 to account for the hemisphere difference in the cyclonic vorticity sign.

@daniloceano
Copy link

A quick update: a have also included the information regarding the northern hemisphere on the documentation overview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants