-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: AlignSAR: An open-source toolbox of SAR benchmark dataset creation for machine learning applications #7281
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
@LC-SAR can you try to fix the compilation error? |
👋 Here is some more info: @LC-SAR - note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it. In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command |
@editorialbot check references |
@editorialbot commands |
Hello @LC-SAR, here are the things you can ask me to do:
|
@editorialbot generate pdf |
Dear Editor, Thanks for reviewing our paper. I have updated my paper.bib (https://github.com/AlignSAR/alignSAR/blob/main/paper/paper.bib) and added the missing doi for all the articles (expecting a book published in 1991 which does not have doi). I have no problem generating the pdf by running https://github.com/AlignSAR/alignSAR/blob/main/.github/workflows/draft_pdf.yml. But when I ran '@editorialbot generate pdf', I encountered the same issue as you identified. I suspect there should be because when submitting, I gave the absolute path for 'Branch with paper.md', like this 'Branch with paper.md (empty if default branch): https://github.com/AlignSAR/alignSAR/tree/main/paper/paper.md'. |
Regarding the potential reviews, I propose those peers in the field of Earth Science. SAR (Synthetic Aperture Radar) and machine learning, with GitHub names: weiji14, jiangyuinsar and rogerkuou |
@editorialbot set main as branch |
Done! branch is now main |
@editorialbot generate pdf |
Five most similar historical JOSS papers: Geodata-Harvester: A Python package to jumpstart geospatial data extraction and analysis PolSAR tools: A QGIS plugin for generating SAR descriptors Synaptus: A Matlab/Octave toolbox for synthetic aperture ultrasound imaging Trash AI: A Web GUI for Serverless Computer Vision Analysis of Images of Trash deeplenstronomy: A dataset simulation package for strong gravitational lensing |
@LC-SAR Sorry I missed that! Hi and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:
In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them. |
Thank you Kristen for your help. Our AlignSAR toolbox follows Apache-2.0 license; Installation instruction is introduced in AlignSAR_tutorial.pdf (https://github.com/AlignSAR/alignSAR/blob/main/AlignSAR_tutorial.pdf), see Section 1.1.; Documentation can be found in https://github.com/AlignSAR/alignSAR/tree/main; demonstration can also found in AlignSAR_tutorial.pdf; Submitted paper has 965 words. Considering research fields in earth science, radar remote sensing, and machine learning, five potential reviewers could be: GitHub names: weiji14, jiangyuinsar, rogerkuou, yotarazona, talha-q |
@editorialbot check repository |
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
@LC-SAR some high level comments:
|
Dear Kristen,
|
Dear @kthyng Kristen, |
Sorry @LC-SAR, I will follow up now.
I don't really understand this response. Can you explain again? I am particularly curious about docs and tutorials that a user could use to start using your software and understand its functionality. The tutorial pdf is excellent, it is just a bit difficult for a user to jump into compared to more modern html like readthedocs. Also having everything in one place is less confusing.
Is Doris all of the library, or just part of it?
Ok, this is good. Normally there would also be unit tests to make sure the software is working correctly during development and for any users who want to contribute to development. This would probably come up during review. |
@editorialbot generate pdf |
Five most similar historical JOSS papers: Geodata-Harvester: A Python package to jumpstart geospatial data extraction and analysis Synaptus: A Matlab/Octave toolbox for synthetic aperture ultrasound imaging PolSAR tools: A QGIS plugin for generating SAR descriptors Trash AI: A Web GUI for Serverless Computer Vision Analysis of Images of Trash deeplenstronomy: A dataset simulation package for strong gravitational lensing |
Please check that your inline vs. parenthetical references are correct. You can compare with the example paper here: https://joss.readthedocs.io/en/latest/example_paper.html. For example, in line 11 you have references in parentheses that shouldn't be. |
Thank you Kristen. I have updated the reference according. See line 11 for the updated manuscript. |
@LC-SAR great, did you see my other questions/comments above? |
Dear Kristen, |
Dear Kristen, Regarding your comment '> I don't really understand this response. Can you explain again? I am particularly curious about docs and tutorials that a user could use to start using your software and understand its functionality. The tutorial pdf is excellent, it is just a bit difficult for a user to jump into compared to more modern html like readthedocs. Also having everything in one place is less confusing.', here is my further explanation: Regarding your question '> Is Doris all of the library, or just part of it?', Doris is one of the tools within AlignSAR toolbox. If you read our manuscript, on page 2, from line 63, we have listed all other tools besides Doris. Thank you, Ling |
@LC-SAR Ok I reread your comments to see that you said all the software can be installed manually, not just Doris. I misunderstood. Thank you for trying with the html vs the pdf. It looks like the formatting doesn't work out very well on the html the way it's processed so best not to do it this way. Some of the comments in this issue are from a bot, editorialbot, and they are just to help out. We have a backlog of submissions so I will add this to our waitlist. Thanks for your patience. |
@rwegener2 Can you edit this submission? |
@editorialbot invite @rwegener2 as editor |
Invitation to edit this submission sent! |
@editorialbot add me as editor |
Assigned! @rwegener2 is now the editor |
👋🏻 Hi @christopheredsall and @xiaxilin, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html |
Submitting author: @LC-SAR (Ling Chang)
Repository: https://github.com/AlignSAR/alignSAR
Branch with paper.md (empty if default branch): main
Version: v1.1
Editor: @rwegener2
Reviewers: Pending
Managing EiC: Kristen Thyng
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @LC-SAR. Currently, there isn't a JOSS editor assigned to your paper.
@LC-SAR if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: