Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: wiliamcformat: A Python tool to process and standardize WILIAM outputs #7299

Closed
editorialbot opened this issue Sep 27, 2024 · 16 comments
Labels
pre-review query-scope Submissions of uncertain scope for JOSS rejected Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Sep 27, 2024

Submitting author: @GPH93 (Gonzalo Parrado-Hernando)
Repository: https://github.com/Tristan22400/IAMC_format
Branch with paper.md (empty if default branch): main
Version: v1.0.0
Editor: Pending
Reviewers: Pending
Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/4dd3e6e120e6ca59ff6b64d7734673c4"><img src="https://joss.theoj.org/papers/4dd3e6e120e6ca59ff6b64d7734673c4/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/4dd3e6e120e6ca59ff6b64d7734673c4/status.svg)](https://joss.theoj.org/papers/4dd3e6e120e6ca59ff6b64d7734673c4)

Author instructions

Thanks for submitting your paper to JOSS @GPH93. Currently, there isn't a JOSS editor assigned to your paper.

@GPH93 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Sep 27, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@crvernon
Copy link

@editorialbot query scope

👋 @GPH93 - I am going to run this one by our larger editorial board due to the code base not being in a community standard packaging format to ensure it meets our substantial scholarly effort requirement. This should take about two weeks at the most. I'll let you know what I hear back ASAP.

In the meantime, you have extra tab indentions in the header of your paper file that are likely the reason this one is not compiling. Could you please fix those? Thanks.

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Sep 27, 2024
@danielskatz
Copy link

@editorialbot check repository

@danielskatz
Copy link

@xuanxu - any idea why this doesn't seem to complete?

@xuanxu
Copy link
Member

xuanxu commented Sep 30, 2024

I think the name of the branch is incorrect, it should be main, not origin/main

@danielskatz
Copy link

@editorialbot set main as branch

@editorialbot
Copy link
Collaborator Author

Done! branch is now main

@danielskatz
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=1.04 s (22.0 files/s, 318970.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSV                              3              0              0         324404
Jupyter Notebook                 9              0           5138           1818
Python                           5            305            296            919
TeX                              1             11              0            135
YAML                             2              2              4            120
Markdown                         2             41              0            100
JSON                             1              0              0              5
-------------------------------------------------------------------------------
SUM:                            23            359           5438         327501
-------------------------------------------------------------------------------

Commit count by author:

    92	Tristan22400
    30	gonzaloparradohernando
    19	Tristan Martin
     3	Tristan Martin - Morpho

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1337

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🔴 Failed to discover a valid open source license

@danielskatz
Copy link

👋 @GPH93 - JOSS requires software that it reviews to be licensed with an OSI-approved license.

@crvernon
Copy link

@editorialbot reject

👋 @GPH93 - After further review with our larger editorial board we have decided that we must reject this submission due to it not meeting our substantial scholarly effort requirements per the following:

  • Not packaged in a way that facilitates testing and reuse per community standards

We wish you the best and thank you for submitting to JOSS.

@editorialbot
Copy link
Collaborator Author

Paper rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review query-scope Submissions of uncertain scope for JOSS rejected Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

4 participants