You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While findMissingResidues can now handle PDBs with residue insertion codes, in addMissingAtoms (which calls _addAtomsToTopology), the new topology with the missing atoms added does not maintain residue insertion codes.
@ivyzhang999 : You should be able to create your own fork of the repo and then contribute the PO from your fork!
We typically don't do that for projects that involve encrypted environment variables because travis does not encrypt them in PRs from forks for security reasons, but that isn't an issue here!
This issue is related to @peastman 's fix: #184
While
findMissingResidues
can now handle PDBs with residue insertion codes, inaddMissingAtoms
(which calls_addAtomsToTopology
), the new topology with the missing atoms added does not maintain residue insertion codes.This should be a simple fix: change this line
newResidue = newTopology.addResidue(residue.name, newChain, residue.id)
(https://github.com/pandegroup/pdbfixer/blob/master/pdbfixer/pdbfixer.py#L401)to
newResidue = newTopology.addResidue(residue.name, newChain, residue.id, residue.insertionCode)
The text was updated successfully, but these errors were encountered: