Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MigratorLEI into Migrations #234

Open
2 tasks
tiredpixel opened this issue Dec 13, 2023 · 0 comments
Open
2 tasks

Refactor MigratorLEI into Migrations #234

tiredpixel opened this issue Dec 13, 2023 · 0 comments

Comments

@tiredpixel
Copy link
Contributor

tiredpixel commented Dec 13, 2023

Refactor RegisterSourcesBods::Services::MigratorLEI into the new RegisterSourcesBods::Migrations method.

This is quite a small task, and the LEI migrations have already been run, but I think there's merit in refactoring and importing it, not only to clean up existing code, but also as a useful reference for how to migrate identifiers.

It should also include refactoring RegisterSourcesOC::Repositories::AddIdRepository search_scroll to use since-added RegisterCommon::Elasticsearch::Query search_scroll instead, further reducing duplication (one function at a time…).

  • RegisterSourcesBods::Services::MigratorLEI
  • RegisterSourcesOC::Repositories::AddIdRepository

This was noted as part of #222 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant