Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check jar file dependencies into source control #17

Open
JLLeitschuh opened this issue Jun 22, 2023 · 0 comments
Open

Don't check jar file dependencies into source control #17

JLLeitschuh opened this issue Jun 22, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@JLLeitschuh
Copy link
Contributor

SourceDirectorySet resources = getProject().getExtensions().getByType(JavaPluginExtension.class)
.getSourceSets()
.getByName("main")
.getResources();

These lines put the dependencies into a file managed by source control. Having large binaries checked into source control is both against git's best practices, and not a great idea from a security perspective.

Instead, the process resources task should be used to add additional resources to the set of resources that end up in the build/resources directory

https://docs.gradle.org/current/dsl/org.gradle.language.jvm.tasks.ProcessResources.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant