From 996709b9757390664535a45eab11011335d951f5 Mon Sep 17 00:00:00 2001
From: Tim te Beek <tim@moderne.io>
Date: Tue, 3 Sep 2024 11:57:23 +0200
Subject: [PATCH] Add Mockito best practices to clear out MockitoSettings

Fixes https://github.com/openrewrite/rewrite-testing-frameworks/issues/589
---
 .../resources/META-INF/rewrite/mockito.yml    | 12 +++
 .../mockito/RemoveMockitoSettingsTest.java    | 73 +++++++++++++++++++
 2 files changed, 85 insertions(+)
 create mode 100644 src/test/java/org/openrewrite/java/testing/mockito/RemoveMockitoSettingsTest.java

diff --git a/src/main/resources/META-INF/rewrite/mockito.yml b/src/main/resources/META-INF/rewrite/mockito.yml
index 0eb563206..b1ddde300 100644
--- a/src/main/resources/META-INF/rewrite/mockito.yml
+++ b/src/main/resources/META-INF/rewrite/mockito.yml
@@ -15,6 +15,18 @@
 #
 ---
 type: specs.openrewrite.org/v1beta/recipe
+name: org.openrewrite.java.testing.mockito.MockitoBestPractices
+displayName: Mockito best practices
+description: .
+tags:
+  - testing
+  - mockito
+recipeList:
+  - org.openrewrite.java.testing.mockito.Mockito1to5Migration
+  - org.openrewrite.java.RemoveAnnotation:
+      annotationPattern: "@org.mockito.junit.jupiter.MockitoSettings(strictness=org.mockito.quality.Strictness.WARN)"
+---
+type: specs.openrewrite.org/v1beta/recipe
 name: org.openrewrite.java.testing.mockito.Mockito1to5Migration
 displayName: Mockito 5.x upgrade
 description: Upgrade Mockito from 1.x to 5.x.
diff --git a/src/test/java/org/openrewrite/java/testing/mockito/RemoveMockitoSettingsTest.java b/src/test/java/org/openrewrite/java/testing/mockito/RemoveMockitoSettingsTest.java
new file mode 100644
index 000000000..0a5a10fd6
--- /dev/null
+++ b/src/test/java/org/openrewrite/java/testing/mockito/RemoveMockitoSettingsTest.java
@@ -0,0 +1,73 @@
+package org.openrewrite.java.testing.mockito;
+
+import org.junit.jupiter.api.Test;
+import org.openrewrite.DocumentExample;
+import org.openrewrite.InMemoryExecutionContext;
+import org.openrewrite.java.JavaParser;
+import org.openrewrite.test.RecipeSpec;
+import org.openrewrite.test.RewriteTest;
+
+import static org.openrewrite.java.Assertions.java;
+
+class RemoveMockitoSettingsTest implements RewriteTest {
+
+    @Override
+    public void defaults(RecipeSpec spec) {
+        spec
+          .parser(JavaParser.fromJavaVersion()
+            .classpathFromResources(new InMemoryExecutionContext(),
+              "mockito-core", "mockito-junit-jupiter", "junit-jupiter-api"))
+          .recipeFromResource("/META-INF/rewrite/mockito.yml", "org.openrewrite.java.testing.mockito.MockitoBestPractices");
+    }
+
+    @Test
+    @DocumentExample
+    void removeMockitoSettings() {
+        rewriteRun(
+          //language=java
+          java(
+            """
+              import org.mockito.junit.jupiter.MockitoSettings;
+              import org.mockito.quality.Strictness;
+              @MockitoSettings(strictness = Strictness.WARN)
+              class A {}
+              """,
+            """
+              class A {}
+              """
+          )
+        );
+    }
+
+    @Test
+    void removeMockitoSettingsFullyQualified() {
+        rewriteRun(
+          //language=java
+          java(
+            """
+              import org.mockito.junit.jupiter.MockitoSettings;
+              @MockitoSettings(strictness = org.mockito.quality.Strictness.WARN)
+              class A {}
+              """,
+            """
+              class A {}
+              """
+          )
+        );
+    }
+
+    @Test
+    void retainMisMatchedArgument() {
+        rewriteRun(
+          //language=java
+          java(
+            """
+              import org.mockito.junit.jupiter.MockitoSettings;
+              import org.mockito.quality.Strictness;
+              @MockitoSettings(strictness = Strictness.LENIENT)
+              class A {}
+              """
+          )
+        );
+    }
+}