Should codelist_update allow a user to upload a new CSV file?

[iaindillingham]

The codelist_create view allows a user to upload a CSV file to create an "old style" codelist.

opencodelists/codelists/views/codelist_create.py

Lines 19 to 25 in 55332b8

	@login_required
	@load_owner
	@require_permission
	def codelist_create(request, owner):
	if request.method == "POST":
	return handle_post(request, owner)
	return handle_get(request)

The CSV file need not adhere to a schema; the data in the CSV file are validated and cleaned and associated with the instance.

However, the corresponding codelist_update view doesn't allow a user to upload a new CSV file to update the codelist.

opencodelists/codelists/views/codelist_update.py

Lines 14 to 22 in 55332b8

	@login_required
	@load_codelist
	@require_permission
	def codelist_update(request, codelist):
	owner_choices = get_owner_choices(codelist, request.user)
	if request.method == "POST":
	return handle_post(request, codelist, owner_choices)
	return handle_get(request, codelist, owner_choices)

@andrewscolm created a codelist from a CSV file that had code, term 1, and term 2 columns. However, he couldn't update this codelist from a new CSV file.¹ Possibly Colm should create a new codelist?

It's not clear whether modifying codelist_update is desirable, given the distinction between "new style" and "old style" codelists.

Footnotes

1. https://bennettoxford.slack.com/archives/C31D62X5X/p1728646729192689 ↩

[lucyb]

We should speak to @andrewscolm and see how much effort it will be for him to create a new codelists and what implications there are if he does this.

[andrewscolm]

To update: this issue was due to opening the csv file with excel rather than the codelist_update function.