Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[De angular] CSS cleanup #4661

Open
2 tasks
ashwin-pc opened this issue Aug 3, 2023 · 2 comments
Open
2 tasks

[De angular] CSS cleanup #4661

ashwin-pc opened this issue Aug 3, 2023 · 2 comments
Labels
de-angular de-angularize work v3.0.0

Comments

@ashwin-pc
Copy link
Member

There are a lot of CSS styles that need to be removed once angular is removed from the application.

Work left

  • /src/core/server/core_app/assets/legacy_dark_theme.css
  • /src/core/server/core_app/assets/legacy_light_theme.css
@ashwin-pc ashwin-pc added the de-angular de-angularize work label Aug 3, 2023
@AMoo-Miki
Copy link
Collaborator

AMoo-Miki commented Sep 22, 2023 •
edited
Loading

@ashwin-pc, these files are merely a rearranged Boostrap stylesheet, modified to match OSD colors and styling, and spiced with some CSS rules devs didn't find another place for putting them. I randomly checked 10 of the class names and 7 were not even used in OSD.

That said, I believe removing these files is a breaking change and as such should not be done in 2.x.

@ashwin-pc ashwin-pc added v3.0.0 and removed v2.11.0 labels Sep 22, 2023
@ashwin-pc
Copy link
Member Author

Moving it to 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
de-angular de-angularize work v3.0.0
Projects
Dashboards DeAngularization
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AMoo-Miki @ashwin-pc