Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] no menu on Dashboard View / saved search at Table #4688

Closed
MSchlick opened this issue Aug 7, 2023 · 5 comments
Closed

[BUG] no menu on Dashboard View / saved search at Table #4688

MSchlick opened this issue Aug 7, 2023 · 5 comments
Assignees
Labels
bug Something isn't working discover for discover reinvent feature-anywhere

Comments

@MSchlick
Copy link

MSchlick commented Aug 7, 2023

Describe the bug

When I added a Table-View to the dashboard, no menu get shown.
Function was given at previous version.

To Reproduce
Steps to reproduce the behavior:

  1. Save Table at Discover
  2. Add it to a Dashboard
  3. Click at ... at the table in dashboard-view
  4. See error in Web-Console

Error

embeddable.plugin.js:6 TypeError: Cannot read properties of undefined (reading 'data')
    at isEligibleForVisLayers (alertingDashboards.plugin.js:44:359259)
    at _callee$ (alertingDashboards.plugin.js:6:868034)
    at tryCatch (queryWorkbenchDashboards.plugin.js:2:2179)
    at Generator._invoke (queryWorkbenchDashboards.plugin.js:2:1802)
    at Generator.next (queryWorkbenchDashboards.plugin.js:2:2954)
    at asyncGeneratorStep (alertingDashboards.plugin.js:6:866337)
    at _next (alertingDashboards.plugin.js:6:866648)
    at alertingDashboards.plugin.js:6:866798
    at new Promise (<anonymous>)
    at Object.<anonymous> (alertingDashboards.plugin.js:6:866560)

Expected behavior
Open menu with inspection an maximize panel

OpenSearch Version
2.9.0

Dashboards Version
2.9.0

Host/Environment (please complete the following information):

  • OS: Rhel
  • Browser and version chrome, edge, firefox

Additional context

Same error on every three installations. 2x new installations, 1x update from 2.8 .
Function at 2.8 was okay.

@MSchlick MSchlick added bug Something isn't working untriaged labels Aug 7, 2023
@joshuarrrr
Copy link
Member

@ohltyler Can you take a look at this and/or assign to someone who worked on the anywhere feature? This appears to be a regression.

@juergen-walter
Copy link

I can confirm this regression after update to 2.9.0 (independent of @MSchlick)

#4694 affects the same js file, also after update 2.9.0. You might want to look a them together.

@ohltyler
Copy link
Member

@lezzago can you help take a look? Looks like an NPE in alerting plugin.

@lezzago
Copy link
Member

lezzago commented Aug 11, 2023

@MSchlick I have pushed out a fix from the above PR.
I have provided the updated 2.9 alerting dahsboards artifact here, for you to update the cluster with the new plugin. This should resolve the issue you are having.

Additionally, you may use the source code for the 2.9 branch to build the artifact and reinstall it on your 2.9 cluster.

@MSchlick
Copy link
Author

Fix from @lezzago is working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discover for discover reinvent feature-anywhere
Projects
None yet
Development

No branches or pull requests

5 participants