Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overview units tests are insufficient #4693

Closed
AMoo-Miki opened this issue Aug 8, 2023 · 1 comment · Fixed by #5418
Closed

Overview units tests are insufficient #4693

AMoo-Miki opened this issue Aug 8, 2023 · 1 comment · Fixed by #5418
Assignees
@thanhinhchtom
Labels
enhancement New feature or request good first issue Good for newcomers OSCI Open Source Contributor Initiative test:unit

Comments

@AMoo-Miki
Copy link
Collaborator

AMoo-Miki commented Aug 8, 2023 •
edited by kavilla
Loading

Overview is pretty complicated and the unit tests don't deal with any of the complications.

Requirements

  • Add more unit tests to handle the features within overview
@AMoo-Miki AMoo-Miki added enhancement New feature or request test:unit labels Aug 8, 2023
@kavilla kavilla added good first issue Good for newcomers OSCI Open Source Contributor Initiative and removed untriaged labels Aug 8, 2023
@thanhinhchtom
Copy link
Contributor

Can I try this?

@thanhinhchtom thanhinhchtom mentioned this issue Oct 24, 2023
Closed
7 tasks
@thanhinhchtom thanhinhchtom mentioned this issue Nov 1, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thanhinhchtom thanhinhchtom

Labels
enhancement New feature or request good first issue Good for newcomers OSCI Open Source Contributor Initiative test:unit
Projects
None yet
Milestone
No milestone
3 participants
@AMoo-Miki @kavilla @thanhinhchtom