Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Explorer] Remove the data explorer wrapper for discover #8194

Open
ashwin-pc opened this issue Sep 13, 2024 · 0 comments
Open

[Data Explorer] Remove the data explorer wrapper for discover #8194

ashwin-pc opened this issue Sep 13, 2024 · 0 comments
Labels
data explorer Issues related to the Data Explorer project discover for discover reinvent technical debt If not paid, jeapardizes long-term success and maintainability of the repository.

Comments

@ashwin-pc
Copy link
Member

Given that we no longer use the data explorer wrapper for its original usecase and have significantly diverged from the original implementation, the existing tech debt should be removed to have a cleaner separation of code and state without this complexity.

The original proposal had Data Explorer be a single app that hosted Discover and Visbuilder hosted within a single container that could share state. Unless we have a need for such an architecture anymore, we should revert back to the simpler architecture.
@ashwin-pc ashwin-pc added technical debt If not paid, jeapardizes long-term success and maintainability of the repository. discover for discover reinvent data explorer Issues related to the Data Explorer project labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data explorer Issues related to the Data Explorer project discover for discover reinvent technical debt If not paid, jeapardizes long-term success and maintainability of the repository.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ashwin-pc