Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code editor library to monaco #338

Open
ohltyler opened this issue Sep 3, 2024 · 0 comments
Open

Update code editor library to monaco #338

ohltyler opened this issue Sep 3, 2024 · 0 comments
Labels
enhancement New feature or request v3.0.0 Issues targeting release v3.0.0

Comments

@ohltyler
Copy link
Member

ohltyler commented Sep 3, 2024

Currently, this plugin uses the legacy EuiCodeEditor which uses ace library under the hood. This is deprecated in favor of the monaco-based CodeEditor component in OSD. However, the version of monaco is >5 years old now, primarily due to webpack issues. This version has bugs, missing features, and in general not good documentation.

Once webpack is upgraded and the monaco dependency is updated, we can switch to use that.

I have a basic working implementation of using the new editor here: https://github.com/ohltyler/dashboards-flow-framework/tree/code-editor
Once the dependency is updated, a rebase and bootstrap on that branch should bring everything up-to-date.

@ohltyler ohltyler added enhancement New feature or request v2.18.0 labels Sep 3, 2024
@ohltyler ohltyler added v3.0.0 Issues targeting release v3.0.0 and removed untriaged v2.18.0 labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v3.0.0 Issues targeting release v3.0.0
Projects
None yet
Development

No branches or pull requests

1 participant