Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate OUI theme compliance - phase 1 #26

Closed
1 of 8 tasks
Tracked by #4291
joshuarrrr opened this issue Jun 15, 2023 · 1 comment
Closed
1 of 8 tasks
Tracked by #4291

Validate OUI theme compliance - phase 1 #26

joshuarrrr opened this issue Jun 15, 2023 · 1 comment
Assignees

Comments

@joshuarrrr
Copy link
Member

joshuarrrr commented Jun 15, 2023

This is a tracking issue for phase 1 of OUI theme plugin compliance, which will involve changes to OUI typography and color SASS variables (for both dark and light mode). For full details, including dates and tooling, see opensearch-project/OpenSearch-Dashboards#4291

If your plugin has no UI views or components, please add a comment to that effect, and we'll remove the repo from future look and feel update campaigns.

Actions required

  • Acknowledge the issue by adding an assignee who will serve as a point-of-contact
  • Provide screenshots and navigation instructions for important views and screens in your plugin or application. This will assist with both manual and automatic validation of compliance
  • Identify all typographic properties and styles
  • Create issues to mitigate typographic styles not inherited from OUI components or SASS variables
  • Identify all color values, including visualization colors and palettes
  • Create issues to mitigate typographic styles not inherited from OUI components or SASS variables
  • Resolve all mitigation issues
  • Validate and test plugin with updated OUI theme

Questions?

Add a comment on opensearch-project/OpenSearch-Dashboards#4291

@joshuarrrr
Copy link
Member Author

I ran both scripts against the repo and also validated that this plugin has no UI views or components. It can be exempted from further OUI compliance campaigns.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Look & Feel Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants