-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Good first issue] Update message shown when a single index is selected in search comparison tool #173
Comments
@kgcreative @lauralexis would appreciate input on this. Thanks! |
One possibility (maybe silly) would be to set the second index to match the first index by default (i.e. when you select the first index, if the second index is unset, then set the second index to match the first index). Of course, you would still need to handle the case where the user explicitly unselects an index. IMO, the "standard" use of search comparison is running functionally "similar" queries on the same index to see what changes. |
A single search is permitted. A single search can be executed on either side (query 1 or query 2). I don't think the error message is necessarily a bug, because it explains why the search wasn't executed. We could adjust the error message for both sides for more clarity to say "An index is required to compare search results. Select an index." Let me know what you think. |
I'd like to keep this as simple as we can right now. I think making the messaging clearer can work just fine, but if someone is willing to pick up @msfroh's suggestion later and that works for the UX then we could do that as well. IMO, updating the text can work to be clearer. If we go down that path, we should also label this "good first issue." |
Thanks all for the great suggestions! To summarize, the next step in resolving this problem is to modify the error message. If someone wants to tweak the UX of this to auto-fill the index, please open a new issue. |
Will this issue be fixed by #267? If not, I can make a PR for this |
Nope it's an seperate issue. Please feel free to take it! |
…h-project#173) Signed-off-by: Evan Kielley <[email protected]>
…opensearch-project#173) Signed-off-by: Evan Kielley <[email protected]>
* Changing select index error message to be more informative (#173) Signed-off-by: Evan Kielley <[email protected]> * Changing select index error message to be a constant to keep code DRY (#173) Signed-off-by: Evan Kielley <[email protected]> * Reverting change to yarn.lock Signed-off-by: Evan Kielley <[email protected]> --------- Signed-off-by: Evan Kielley <[email protected]>
* Changing select index error message to be more informative (#173) Signed-off-by: Evan Kielley <[email protected]> * Changing select index error message to be a constant to keep code DRY (#173) Signed-off-by: Evan Kielley <[email protected]> * Reverting change to yarn.lock Signed-off-by: Evan Kielley <[email protected]> --------- Signed-off-by: Evan Kielley <[email protected]> (cherry picked from commit dff6559) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…) (#275) * Changing select index error message to be more informative (#173) * Changing select index error message to be a constant to keep code DRY (#173) * Reverting change to yarn.lock --------- (cherry picked from commit dff6559) Signed-off-by: Evan Kielley <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
What is the bug?
When the search button is pressed and a single search is performed, an error message appears saying "An index is required. Select an index."
How can one reproduce the bug?
What is the expected behavior?
Three possibilities:
Do you have any additional context?
I would want to clarify the expected behavior.
The text was updated successfully, but these errors were encountered: