You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a few issues with how this plugin is set up name-wise and folder-wise. If the plan was to eventually include other visualisations, this plan has been superceded by the one-plugin-per-repo decision.
this is a visualization-plugin to visualize in dashboards visualization system. We are add-ing new visualization and widgets here to make them pluggable in to Dashboards.
cc: @peter fitz & @joshuali925 ; we will dedicate some time after 2.7 release to review this.
Question : do we have a naming convention for visualization plugins ? should we extend that ? and also introduce widgets
This is not an Dashboards plugin, but a visualization plugin inside dashboards.
anirudha
changed the title
[BUG] Names don't adhere to plugin naming convention
[Decide] how do we name , organize and build visualization plugin/ widgets
Apr 11, 2023
There are a few issues with how this plugin is set up name-wise and folder-wise. If the plan was to eventually include other visualisations, this plan has been superceded by the one-plugin-per-repo decision.
Additionally, as per https://github.com/opensearch-project/opensearch-plugins/blob/main/CONVENTIONS.md#plugin-naming-conventions, the plug-in name does not adhere to the naming convention.
Also, as per opensearch-project/opensearch-build#2188, we should get rid of the gantt-chart folder and move build.gradle, etc. to the root folder of the repo.
There is also the option of renaming this entire plugin, as it seems to just be the gantt chart rather than "visualizations."
Should this be a plugin at all?
Referred to here:
opensearch-project/opensearch-plugins#174
The text was updated successfully, but these errors were encountered: