From 2cd9e693365d41a79d0d9850a963a2823dfef0e3 Mon Sep 17 00:00:00 2001 From: David Venable Date: Wed, 23 Aug 2023 12:41:19 -0700 Subject: [PATCH] Improvements in the release.yml GitHub Action: Better conditional to fail the promote if the build fails, increased the timeout, added the issues write permissions, string literal correction. (#3224) Signed-off-by: David Venable --- .github/workflows/release.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 1e772923ee..e663de4e1d 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -4,23 +4,24 @@ on: workflow_dispatch: inputs: release-major-tag: - description: 'Whether to create major tag of docker image or not. This will create a tag such as 2.3 which points to this version.' + description: 'Whether to create major tag of docker image or not. This will create a tag such as 2 which points to this version.' required: true type: boolean release-latest-tag: description: > - 'Whether to create latest tag of docker image or not. This will update the latest tag to point to this version. You should set this when releasing the latest version, but not patches to old versions.' + Whether to create latest tag of docker image or not. This will update the latest tag to point to this version. You should set this when releasing the latest version, but not patches to old versions. required: true type: boolean permissions: id-token: write contents: write + issues: write jobs: build: runs-on: ubuntu-latest - timeout-minutes: 30 + timeout-minutes: 50 steps: - name: Set up JDK @@ -109,7 +110,7 @@ jobs: promote: runs-on: ubuntu-latest - if: success() || failure() + if: ${{ (success() || failure()) && needs.build.result == 'success' }} needs: [build, validate-docker, validate-archive] permissions: contents: write