Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse sigv4 signing interceptor between opensearch source and sink, include unit tests #2809

Closed
graytaylor0 opened this issue Jun 2, 2023 · 1 comment
Labels
maintenance Issues to help maintain the project, such as improving builds, testing, etc. untriaged

Comments

@graytaylor0
Copy link
Member

Is your feature request related to a problem? Please describe.
This class referenced here (91fabf4#r1213996924) is copy pasted between the opensearch sink and opensearch source for sigv4 signing, and it does not contain any unit tests.

Describe the solution you'd like
Move this class to the aws-plugin-api via an extension point for reuse between the opensearch source and sink, and anywhere else it is needed in the future. Also add unit tests once this class is moved to the aws-plugin-api

Describe alternatives you've considered (Optional)
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@graytaylor0
Copy link
Member Author

graytaylor0 commented Jun 10, 2023

Closing as this class is not being reused in the opensearch source and is not needed anymore with changes to the opensearch java client.

@github-project-automation github-project-automation bot moved this from Unplanned to Done in Data Prepper Tracking Board Jun 10, 2023
@graytaylor0 graytaylor0 reopened this Sep 5, 2023
@github-project-automation github-project-automation bot moved this from To do to In progress in Data Prepper Tracking Board Sep 5, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in Data Prepper Tracking Board Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues to help maintain the project, such as improving builds, testing, etc. untriaged
Projects
Archived in project
Development

No branches or pull requests

1 participant