Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support formatting of the document_id_field in the OpenSearch sink #3074

Closed
graytaylor0 opened this issue Jul 28, 2023 · 0 comments · Fixed by #3153
Closed

Support formatting of the document_id_field in the OpenSearch sink #3074

graytaylor0 opened this issue Jul 28, 2023 · 0 comments · Fixed by #3153
Labels
enhancement New feature or request

Comments

@graytaylor0
Copy link
Member

graytaylor0 commented Jul 28, 2023

Is your feature request related to a problem? Please describe.

In the index parameter of the OpenSearch sink this format is supported to format from multiple keys or expression results in the Event

index: "${key-one}-${key-two}-${getMetadata(\"some_metadata_key\")"

but document_id_field has never supported the format option, so it has to either be

document_id_field: "some_key"

or

document_id_field: "getMetadata(\"some_metadata_key\")"

Describe the solution you'd like
To allow the same formatting as index for document_id_field, but without breaking the existing one (if a temporary document_id_field_format option is needed until it is possible to make a breaking change, then that works as well. It may be possible to do now without breaking the existing functionality though

document_id_field: "${key-one}-${key-two}-${getMetadata(\"some_metadata_key\")}"

Describe alternatives you've considered (Optional)
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant