Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unit Test] Remove sleeps from KafkaSourceCustomConsumerTest #3263

Closed
hshardeesi opened this issue Aug 26, 2023 · 2 comments · Fixed by #3358
Closed

[Unit Test] Remove sleeps from KafkaSourceCustomConsumerTest #3263

hshardeesi opened this issue Aug 26, 2023 · 2 comments · Fixed by #3358
Labels
maintenance Issues to help maintain the project, such as improving builds, testing, etc.
Milestone
v2.5

Comments

@hshardeesi
Copy link
Contributor

Multiple unit tests in KafkaSourceCustomConsumerTest have Thread.sleep(10s). This increases the data prepper build time. Sleep appears to be present for acknowledgements framework to complete acknowledgements. This sim is to track improvement in the unit-tests to mock acknowledgement framework apis and remove Thread.sleep().
@hshardeesi hshardeesi mentioned this issue Aug 26, 2023
Merged
@asifsmohammed asifsmohammed added maintenance Issues to help maintain the project, such as improving builds, testing, etc. and removed untriaged labels Aug 30, 2023
@dlvenable
Copy link
Member

@kkondaka , Did you resolve this? I think you were working on this some recently.

@kkondaka
Copy link
Collaborator

kkondaka commented Oct 6, 2023

Resolved by #3358

@kkondaka kkondaka closed this as completed Oct 6, 2023
@github-project-automation github-project-automation bot moved this from Unplanned to Done in Data Prepper Tracking Board Oct 6, 2023
@kkondaka kkondaka mentioned this issue Sep 19, 2023
Merged
2 tasks
@kkondaka kkondaka added this to the v2.5 milestone Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Issues to help maintain the project, such as improving builds, testing, etc.
Projects
Data Prepper Tracking Board
Archived in project
Milestone
v2.5
4 participants
@dlvenable @hshardeesi @asifsmohammed @kkondaka