Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Exception handling for aws glue schema registry #3264

Closed
hshardeesi opened this issue Aug 26, 2023 · 0 comments · Fixed by #3265
Closed

[BUG] Exception handling for aws glue schema registry #3264

hshardeesi opened this issue Aug 26, 2023 · 0 comments · Fixed by #3265
Labels
bug Something isn't working

Comments

@hshardeesi
Copy link
Contributor

hshardeesi commented Aug 26, 2023 •
edited
Loading

Describe the bug
Kafka source plugin retries every 30s when it hits AWSSchemaRegistryException, which includes both access denied and deserialization errors. As a result, deserialization errors are also retried instead of skipping the records that failed to get deserialized.

Expected behavior

  • Kafka source plugin should retry only if the rootCause of AWSSchemaRegistryException is AccessDenied.
  • In all other cases, records that failed to get deserialized should be skipped (dlq in future) to avoid blocking stream processing.
@hshardeesi hshardeesi added bug Something isn't working untriaged labels Aug 26, 2023
hshardeesi added a commit to hshardeesi/data-prepper that referenced this issue Aug 26, 2023
@hshardeesi
Fix for kafka source issue opensearch-project#3264 (aws glue excetion…
c28a7c5 
… handling)

Signed-off-by: Hardeep Singh <[email protected]>
@hshardeesi hshardeesi mentioned this issue Aug 26, 2023
Merged
asifsmohammed pushed a commit that referenced this issue Aug 27, 2023
@hshardeesi
Fix for kafka source issue #3264 (aws glue excetion handling) (#3265)
d908c40
@github-project-automation github-project-automation bot moved this from Unplanned to Done in Data Prepper Tracking Board Aug 27, 2023
opensearch-trigger-bot bot pushed a commit that referenced this issue Aug 27, 2023
@hshardeesi @github-actions
Fix for kafka source issue #3264 (aws glue excetion handling) (#3265)
0cc489a 
(cherry picked from commit d908c40)
asifsmohammed pushed a commit that referenced this issue Aug 27, 2023
@opensearch-trigger-bot @hshardeesi
Fix for kafka source issue #3264 (aws glue excetion handling) (#3265) (…
1cbb58c 
…#3266)

(cherry picked from commit d908c40)

Co-authored-by: Hardeep Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Data Prepper Tracking Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for kafka source issue #3264 (aws glue excetion handling) hshardeesi/data-prepper
2 participants
@dlvenable @hshardeesi