Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Merging PipelineDataflowModel instead of pipeline YAML files #3289

Closed
chenqi0805 opened this issue Aug 29, 2023 · 1 comment · Fixed by #3290
Closed

[core] Merging PipelineDataflowModel instead of pipeline YAML files #3289

chenqi0805 opened this issue Aug 29, 2023 · 1 comment · Fixed by #3290
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@chenqi0805
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently user is allowed to distribute pipeline configuration bodies across multiple YAML files and Data Prepper will merge them together before converting into internal PipelineDataflowModel. This will require any shared pipeline configuration to be applied to all pipeline config files even if it is only defined in one of those files. Thus blurring the usage of pipeline config file versus data prepper config file which is supposed to include global settings.

Describe the solution you'd like
Instead of merging the pipeline config body from files together, we should first parse each file into its own PipelineDataflowModel and then merge them into a single PipelineDataflowModel.

Describe alternatives you've considered (Optional)
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@dlvenable
Copy link
Member

I also think this resolves a few issues which I've seen:

  • When using multiple pipelines, the line numbers are only accurate for the first file loaded.
  • The version property does not work with multiple files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants