diff --git a/.github/workflows/cypress-workflow.yml b/.github/workflows/cypress-workflow.yml
index dfd61c854..e6db2a344 100644
--- a/.github/workflows/cypress-workflow.yml
+++ b/.github/workflows/cypress-workflow.yml
@@ -82,13 +82,13 @@ jobs:
wait-on: 'http://localhost:5601'
browser: chrome
# Screenshots are only captured on failure, will change this once we do visual regression tests
- - uses: actions/upload-artifact@v1
+ - uses: actions/upload-artifact@v3
if: failure()
with:
name: cypress-screenshots
path: OpenSearch-Dashboards/plugins/index-management-dashboards-plugin/cypress/screenshots
# Test run video was always captured, so this action uses "always()" condition
- - uses: actions/upload-artifact@v1
+ - uses: actions/upload-artifact@v3
if: always()
with:
name: cypress-videos
diff --git a/public/pages/CreateIndexTemplate/containers/CreateIndexTemplate/__snapshots__/CreateIndexTemplate.test.tsx.snap b/public/pages/CreateIndexTemplate/containers/CreateIndexTemplate/__snapshots__/CreateIndexTemplate.test.tsx.snap
index 18faee626..874d94be4 100644
--- a/public/pages/CreateIndexTemplate/containers/CreateIndexTemplate/__snapshots__/CreateIndexTemplate.test.tsx.snap
+++ b/public/pages/CreateIndexTemplate/containers/CreateIndexTemplate/__snapshots__/CreateIndexTemplate.test.tsx.snap
@@ -211,7 +211,7 @@ exports[` spec render template pages 1`] = `
) =>
))}
-
+
>
) : null}
{subCompontentProps.readonly ? null : (
diff --git a/public/pages/IndexDetail/containers/IndexDetail/IndexDetail.tsx b/public/pages/IndexDetail/containers/IndexDetail/IndexDetail.tsx
index ed90332b8..722d54f9d 100644
--- a/public/pages/IndexDetail/containers/IndexDetail/IndexDetail.tsx
+++ b/public/pages/IndexDetail/containers/IndexDetail/IndexDetail.tsx
@@ -150,7 +150,7 @@ export default function IndexDetail(props: IndexDetailModalProps) {
mode: IndicesUpdateMode.settings,
content: (
<>
-
+
Index settings
@@ -168,7 +168,7 @@ export default function IndexDetail(props: IndexDetailModalProps) {
mode: IndicesUpdateMode.mappings,
content: (
<>
-
+
Index mappings
@@ -206,7 +206,7 @@ export default function IndexDetail(props: IndexDetailModalProps) {
mode: IndicesUpdateMode.alias,
content: (
<>
-
+
Index alias
diff --git a/public/pages/Indices/components/IndexControls/IndexControls.tsx b/public/pages/Indices/components/IndexControls/IndexControls.tsx
index d4b177221..b6e429f48 100644
--- a/public/pages/Indices/components/IndexControls/IndexControls.tsx
+++ b/public/pages/Indices/components/IndexControls/IndexControls.tsx
@@ -15,6 +15,7 @@ import {
EuiSearchBar,
EuiCompressedSwitch,
EuiButtonEmpty,
+ EuiToolTip,
} from "@elastic/eui";
import { DataStream, ManagedCatIndex } from "../../../../../server/models/interfaces";
import IndicesActions from "../../containers/IndicesActions";
@@ -96,7 +97,9 @@ export default class IndexControls extends Component
-
+
+
+
{
-
+
Manage channels
- <>
- {noPermission ? (
-
-
- {" "}
- Error loading Notification settings
{" "}
-
- }
- body={
-
- {" "}
- You do not have permissions to view Notification settings. Contact your administrator to request permissions.
-
- }
- />
-
- ) : (
-
- {submitClicked && allErrors.length ? (
-
-
- {allErrors.reduce((total, [key, errors]) => {
- const pattern = /^dataSource\.(\d+)\.(\w+)$/;
- const matchResult = key.match(pattern);
- if (matchResult) {
- const index = matchResult[1];
- const itemField = matchResult[2];
- const notificationItem = (field.getValues().dataSource || [])[parseInt(index, 10)];
- const errorMessagePrefix = `${notificationItem.title} — ${
- FieldMapLabel[itemField as keyof typeof FieldMapLabel]
- }: `;
- return [
- ...total,
- ...(errors || []).map((item) => (
- -
- {errorMessagePrefix}
- {item}
-
- )),
- ];
- }
+ {noPermission ? (
+
+ {" "}
+ Error loading Notification settings
{" "}
+
+ }
+ body={
+
+ {" "}
+ You do not have permissions to view Notification settings. Contact your administrator to request permissions.
+
+ }
+ />
+ ) : (
+ <>
+ {submitClicked && allErrors.length ? (
+
+
+ {allErrors.reduce((total, [key, errors]) => {
+ const pattern = /^dataSource\.(\d+)\.(\w+)$/;
+ const matchResult = key.match(pattern);
+ if (matchResult) {
+ const index = matchResult[1];
+ const itemField = matchResult[2];
+ const notificationItem = (field.getValues().dataSource || [])[parseInt(index, 10)];
+ const errorMessagePrefix = `${notificationItem.title} — ${FieldMapLabel[itemField as keyof typeof FieldMapLabel]}: `;
+ return [
+ ...total,
+ ...(errors || []).map((item) => (
+ -
+ {errorMessagePrefix}
+ {item}
+
+ )),
+ ];
+ }
- return total;
- }, [] as ReactChild[])}
-
-
- ) : null}
-
- {(values.dataSource || []).map((record) => {
- const { value, onChange, ...others } = field.registerField({
- name: ["dataSource", `${record.index}`, FieldEnum.channels],
- rules: [
- {
- validator(rule, value) {
- const values = field.getValues();
- const item = values.dataSource?.[record.index];
- if (item?.[FieldEnum.failure] || item?.[FieldEnum.success]) {
- if (!value || !value.length) {
- return Promise.reject(VALIDATE_ERROR_FOR_CHANNELS);
- }
+ return total;
+ }, [] as ReactChild[])}
+
+
+ ) : null}
+
+ {(values.dataSource || []).map((record) => {
+ const { value, onChange, ...others } = field.registerField({
+ name: ["dataSource", `${record.index}`, FieldEnum.channels],
+ rules: [
+ {
+ validator(rule, value) {
+ const values = field.getValues();
+ const item = values.dataSource?.[record.index];
+ if (item?.[FieldEnum.failure] || item?.[FieldEnum.success]) {
+ if (!value || !value.length) {
+ return Promise.reject(VALIDATE_ERROR_FOR_CHANNELS);
}
+ }
- return Promise.resolve("");
- },
+ return Promise.resolve("");
},
- ],
- });
- return (
-
-
- {" "}
- {record.title}
{" "}
-
-
- }
- helpText={ActionTypeMapDescription[getKeyByValue(ActionTypeMapTitle, record.title) as ActionType]}
- direction="hoz"
- key={record.action_name}
- >
- <>
-
-
-
-
-
-
-
-
-
-
- {field.getValue(["dataSource", `${record.index}`, FieldEnum.failure]) ||
- field.getValue(["dataSource", `${record.index}`, FieldEnum.success]) ? (
- <>
-
-
-
-
- >
- ) : null}
- >
-
- );
- })}
-
-
- )}
- >
+ },
+ ],
+ });
+ return (
+
+
+ {" "}
+ {record.title}
{" "}
+
+
+ }
+ helpText={ActionTypeMapDescription[getKeyByValue(ActionTypeMapTitle, record.title) as ActionType]}
+ direction="hoz"
+ key={record.action_name}
+ >
+ <>
+
+
+
+
+
+
+
+
+
+
+ {field.getValue(["dataSource", `${record.index}`, FieldEnum.failure]) ||
+ field.getValue(["dataSource", `${record.index}`, FieldEnum.success]) ? (
+ <>
+
+
+
+
+ >
+ ) : null}
+ >
+
+ );
+ })}
+
+ >
+ )}
= ({
const renderCancel = useCallback(
() => (
-
+
Cancel
),
@@ -51,7 +49,6 @@ const UnsavedChangesButtons: React.FC = ({
onClick={onClick}
isLoading={loading}
disabled={loading}
- iconType="check"
color="primary"
fill
>
@@ -62,27 +59,28 @@ const UnsavedChangesButtons: React.FC = ({
);
return (
-
- <>
+
+
{formErrorsCount ? (
- {" "}
- {formErrorsCount} form errors{" "}
+ {formErrorsCount} form errors
) : null}
{unsavedCount && !formErrorsCount ? (
- {" "}
- {unsavedCount} unsaved changes{" "}
+ {unsavedCount} unsaved changes
) : null}
- >
- {renderCancel()}
- {renderConfirm()}
+
+
+
+ {renderCancel()}
+ {renderConfirm()}
+
);
};
diff --git a/public/pages/Indices/containers/Indices/Indices.tsx b/public/pages/Indices/containers/Indices/Indices.tsx
index e5c302aad..2e094b057 100644
--- a/public/pages/Indices/containers/Indices/Indices.tsx
+++ b/public/pages/Indices/containers/Indices/Indices.tsx
@@ -300,7 +300,6 @@ export class Indices extends MDSEnabledComponent {
run: this.toggleNotificationModal,
testId: "notificationSettingsButton",
controlType: "button",
- color: "secondary",
} as TopNavControlButtonData,
{
id: "Create index",
diff --git a/public/pages/ManagedIndices/components/ManagedIndexControls/ManagedIndexControls.tsx b/public/pages/ManagedIndices/components/ManagedIndexControls/ManagedIndexControls.tsx
index 02a694f77..8ece22607 100644
--- a/public/pages/ManagedIndices/components/ManagedIndexControls/ManagedIndexControls.tsx
+++ b/public/pages/ManagedIndices/components/ManagedIndexControls/ManagedIndexControls.tsx
@@ -14,6 +14,7 @@ import {
EuiButtonIcon,
EuiButtonEmpty,
EuiSpacer,
+ EuiToolTip,
} from "@elastic/eui";
import { DataStream } from "../../../../../server/models/interfaces";
import { getUISettings } from "../../../../services/Services";
@@ -43,7 +44,7 @@ export default class ManagedIndexControls extends Component
-
+
+
+
{Actions}
diff --git a/public/pages/ManagedIndices/containers/ManagedIndices/ManagedIndices.tsx b/public/pages/ManagedIndices/containers/ManagedIndices/ManagedIndices.tsx
index 1c52b62e9..3a182621d 100644
--- a/public/pages/ManagedIndices/containers/ManagedIndices/ManagedIndices.tsx
+++ b/public/pages/ManagedIndices/containers/ManagedIndices/ManagedIndices.tsx
@@ -121,7 +121,6 @@ export class ManagedIndices extends MDSEnabledComponent {index},
},
{
@@ -130,7 +129,6 @@ export class ManagedIndices extends MDSEnabledComponent dataStream || DEFAULT_EMPTY_DATA,
},
{
@@ -139,7 +137,6 @@ export class ManagedIndices extends MDSEnabledComponent state || DEFAULT_EMPTY_DATA,
},
@@ -156,7 +152,6 @@ export class ManagedIndices extends MDSEnabledComponent (
{(action || DEFAULT_EMPTY_DATA).split("_").join(" ")}
@@ -168,7 +163,6 @@ export class ManagedIndices extends MDSEnabledComponent (
{({ onShow }) => (
@@ -184,7 +178,6 @@ export class ManagedIndices extends MDSEnabledComponent {
const { managedIndexMetaData } = item;
if (!managedIndexMetaData) return "Initializing";
diff --git a/public/pages/ManagedIndices/containers/ManagedIndices/__snapshots__/ManagedIndices.test.tsx.snap b/public/pages/ManagedIndices/containers/ManagedIndices/__snapshots__/ManagedIndices.test.tsx.snap
index c16dbbe06..cb8426d69 100644
--- a/public/pages/ManagedIndices/containers/ManagedIndices/__snapshots__/ManagedIndices.test.tsx.snap
+++ b/public/pages/ManagedIndices/containers/ManagedIndices/__snapshots__/ManagedIndices.test.tsx.snap
@@ -348,7 +348,6 @@ exports[` spec renders the component 1`] = `
data-test-subj="tableHeaderCell_index_0"
role="columnheader"
scope="col"
- style="width: 150px;"
>
spec renders the component 1`] = `
data-test-subj="tableHeaderCell_policyId_1"
role="columnheader"
scope="col"
- style="width: 140px;"
>
spec renders the component 1`] = `
data-test-subj="tableHeaderCell_managedIndexMetaData.state.name_2"
role="columnheader"
scope="col"
- style="width: 150px;"
>
spec renders the component 1`] = `
data-test-subj="tableHeaderCell_managedIndexMetaData.action.name_3"
role="columnheader"
scope="col"
- style="width: 150px;"
>
spec renders the component 1`] = `
data-test-subj="tableHeaderCell_managedIndexMetaData.info_4"
role="columnheader"
scope="col"
- style="width: 150px;"
>
spec renders the component 1`] = `
data-test-subj="tableHeaderCell_index_5"
role="columnheader"
scope="col"
- style="width: 150px;"
>
{
controlType: "button",
display: "base",
iconType: "popout",
+ iconSide: "right",
fill: true,
} as TopNavControlButtonData,
];
diff --git a/public/pages/Policies/containers/Policies/Policies.tsx b/public/pages/Policies/containers/Policies/Policies.tsx
index 92c11b27d..d7a671eb0 100644
--- a/public/pages/Policies/containers/Policies/Policies.tsx
+++ b/public/pages/Policies/containers/Policies/Policies.tsx
@@ -111,7 +111,6 @@ export class Policies extends MDSEnabledComponent
sortable: true,
truncateText: true,
textOnly: true,
- width: "150px",
render: (name: string, item: PolicyItem) => (
this.props.history.push(`${ROUTES.POLICY_DETAILS}?id=${name}`)} data-test-subj={`policyLink_${name}`}>
{name}
@@ -124,7 +123,6 @@ export class Policies extends MDSEnabledComponent
sortable: true,
truncateText: true,
textOnly: true,
- width: "150px",
},
{
field: "policy.last_updated_time",
@@ -133,7 +131,6 @@ export class Policies extends MDSEnabledComponent
truncateText: false,
render: renderTime,
dataType: "date",
- width: "150px",
},
];
}
diff --git a/public/pages/Policies/containers/Policies/__snapshots__/Policies.test.tsx.snap b/public/pages/Policies/containers/Policies/__snapshots__/Policies.test.tsx.snap
index 66e54858e..ff5e4cb18 100644
--- a/public/pages/Policies/containers/Policies/__snapshots__/Policies.test.tsx.snap
+++ b/public/pages/Policies/containers/Policies/__snapshots__/Policies.test.tsx.snap
@@ -254,7 +254,6 @@ exports[` spec renders the component 1`] = `
data-test-subj="tableHeaderCell_id_0"
role="columnheader"
scope="col"
- style="width: 150px;"
>
spec renders the component 1`] = `
data-test-subj="tableHeaderCell_policy.description_1"
role="columnheader"
scope="col"
- style="width: 150px;"
>
spec renders the component 1`] = `
data-test-subj="tableHeaderCell_policy.last_updated_time_2"
role="columnheader"
scope="col"
- style="width: 150px;"
>
-
+
+
+
-
Snapshot policies
- }
- actions={actions}
+ }
+ actions={actions}
subTitleText={subTitleText}
>
@@ -605,7 +606,9 @@ export class SnapshotPolicies extends MDSEnabledComponent
-
+
+
+
{
- return [];
+ return [
+ <>
+
+
+
+ >,
+ ];
};
const currentStage = stage.slice(0, stage.indexOf(" "));
diff --git a/public/pages/Snapshots/containers/Snapshots/Snapshots.tsx b/public/pages/Snapshots/containers/Snapshots/Snapshots.tsx
index 17bd808e0..c066228e2 100644
--- a/public/pages/Snapshots/containers/Snapshots/Snapshots.tsx
+++ b/public/pages/Snapshots/containers/Snapshots/Snapshots.tsx
@@ -23,6 +23,7 @@ import {
EuiButtonIcon,
EuiButton,
EuiPanel,
+ EuiToolTip,
} from "@elastic/eui";
import { FieldValueSelectionFilterConfigType } from "@elastic/eui/src/components/search_bar/filters/field_value_selection_filter";
import { CoreServicesContext } from "../../../../components/core_services";
@@ -466,7 +467,11 @@ export class Snapshots extends MDSEnabledComponent {
return [
- ,
+ <>
+
+
+
+ >,
= ({ filterIsApplied, loa
}
return (
-
+
Create transform
);
diff --git a/public/pages/Transforms/containers/Transforms/Transforms.tsx b/public/pages/Transforms/containers/Transforms/Transforms.tsx
index fc503fffe..094ae665b 100644
--- a/public/pages/Transforms/containers/Transforms/Transforms.tsx
+++ b/public/pages/Transforms/containers/Transforms/Transforms.tsx
@@ -27,6 +27,8 @@ import {
EuiTableSelectionType,
EuiTableSortingType,
EuiSpacer,
+ EuiToolTip,
+ EuiButtonIcon,
} from "@elastic/eui";
import queryString from "query-string";
import { RouteComponentProps } from "react-router-dom";
@@ -297,6 +299,18 @@ export class Transforms extends MDSEnabledComponent
)}
+
+
+
+
+