Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Ensure the OSD server starts before cypress test running #938

Open
bowenlan-amzn opened this issue Nov 17, 2023 · 1 comment
Open
Assignees
Labels

Comments

@bowenlan-amzn
Copy link
Member

We had a flaky test — aliases.js which is the first cypress test because the OSD server hasn't started before. #920 (comment)

@kohinoor98 comes up with a solution to wait for the first API call from test to complete
While on the other hand we can try ensure the OSD server starts before running cypress tests, and here are 2 existing ways worth to take a look.

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/f6ce6e707035f791ed98a9edeab785d0785a8dbd/.github/workflows/cypress_workflow.yml#L149

# timeout 300 bash -c 'while [[ "$(curl -s localhost:5601/api/status | jq -r '.status.overall.state')" != "green" ]]; do sleep 5; done'

@bowenlan-amzn bowenlan-amzn added enhancement New feature or request untriaged testing and removed enhancement New feature or request untriaged labels Nov 17, 2023
@kohinoor98
Copy link
Contributor

Hi @bowenlan-amzn

Please could I take this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants