Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] support default model id in neural_sparse query #610

Closed
zhichao-aws opened this issue Feb 22, 2024 · 3 comments
Closed

[FEATURE] support default model id in neural_sparse query #610

zhichao-aws opened this issue Feb 22, 2024 · 3 comments
Assignees
@zhichao-aws
Labels
enhancement v2.13.0

Comments

@zhichao-aws
Copy link
Member

Is your feature request related to a problem?

Currently, users need to provide the model_id in neural_sparse query. This is not convinient and requires more effort to maintain the model id. We should support default model id in neural_sparse query just like neural query and hybrid query.

ref: #70 #337
@zhichao-aws
Copy link
Member Author

zhichao-aws commented Feb 22, 2024 •
edited
Loading

Please assign this ticket to me. It is targeting the 2.13 release.

@vibrantvarun
Copy link
Member

vibrantvarun commented Feb 22, 2024 •
edited
Loading

#541

@zhichao-aws sharing this PR for reference.

@zhichao-aws zhichao-aws mentioned this issue Feb 26, 2024
Merged
5 tasks
@vibrantvarun
Copy link
Member

Closing this issue as PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhichao-aws zhichao-aws

Labels
enhancement v2.13.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@heemin32 @vibrantvarun @zhichao-aws