-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Deep nested map type configuration issue in text_embedding processor #686
Comments
Hi, I'll look into this! Seems like a issue with nesting of depth of 2. |
@krishy91 Since we're supporting list of map type, we don't want any limitation on this, e.g. supporting only depth of 2 or 3. We should consider to support deeply nested cases if possible. |
Could reproduce the issue. Will push the fix & additional integrration test for such deep nesting cases. |
@krishy91 Is there any update on the fix? |
@zane-neo Is this still an issue? Can this be fixed? |
Yes, this is still an issue, it seems @krishy91 doesn't have bandwidth on this, I'll pick up this. |
What is the bug?
When configured with deep nested map type configuration in text_embedding processor, the embedding result will override the original value of document key:
pipeline configuration:
And simulate the pipeline processor:
Result:
Expected result:
How can one reproduce the bug?
Steps to reproduce the behavior.
What is the expected behavior?
The generated embedding results should be placed in the right position of the document.
What is your host/environment?
Operating system, version.
Do you have any screenshots?
If applicable, add screenshots to help explain your problem.
Do you have any additional context?
Add any other context about the problem.
The text was updated successfully, but these errors were encountered: