Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Code coverage event based report is disabled #974

Closed
martin-gaievski opened this issue Nov 5, 2024 · 4 comments
Closed

[BUG] Code coverage event based report is disabled #974

martin-gaievski opened this issue Nov 5, 2024 · 4 comments
Labels
bug Something isn't working Infrastructure

Comments

@martin-gaievski
Copy link
Member

What is the bug?

Code coverage is broken for the repo. Report is showing some data, but latest commit that has been consumed is 6 months old: https://app.codecov.io/gh/opensearch-project/neural-search. Also recent PRs are missing this report, check out the most recent PR merged at time of writing #971

@yuye-aws
Copy link
Member

yuye-aws commented Nov 7, 2024

The PR has been merged. @martin-gaievski Can you check whether this issue has been resolved?

@martin-gaievski
Copy link
Member Author

I want to keep this open for some time. I see for my PR coverage got updated, but one after PR has failed. Let's gather more info before we conclude if that is fixed or not

@martin-gaievski
Copy link
Member Author

I'm seeing the coverage report got uploaded for some recent PRs (#978), I think we're good to close this issue

@github-project-automation github-project-automation bot moved this from Backlog to ✅ Done in Vector Search RoadMap Nov 8, 2024
@martin-gaievski
Copy link
Member Author

Infra team has opened issue to improve upload of the code coverage report, this is the issue opensearch-project/opensearch-build#5178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Infrastructure
Projects
Status: Done
Development

No branches or pull requests

2 participants