You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Normally, tests for plugins are written without the security plugin installed (sometimes by no choice of the plugin itself).
When written they are written using the default OpenSearch Dashboards index: .kibana. However, when the security plugin is installed, we noticed plugin failures in their tests. When the plugin is installed then this default index translates to the global tenant. Digging deeper, we see that FTRepo's default tenant when the plugin is installed is the private tenant. [source]. This equates to creating an index like .kibana_random_user and it ends up causing failures in the tests because some functions and tests were not expecting this.
For example: we can see the data explorer tests uses a bulk upload helper function to upload a fixture that uses .kibana. But this then becomes problematic because the actual saved objects, like index patterns, get pushed the global tenant but the test will navigate to a page referencing the private tenant. A common behavior we see is that OpenSearch Dashboards will see that the cluster has data indices but no index patterns so it will re-route tests to the index-patterns page by default and say please create an index pattern.
Current mitigations proved successful to solve this issue: #959 #1073
What solution would you like?
Since most of the tests are written using .kibana, we should switch the default tenant to be the global tenant. And modify the security plugin tests to switch to the private tenant.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem?
Normally, tests for plugins are written without the security plugin installed (sometimes by no choice of the plugin itself).
When written they are written using the default OpenSearch Dashboards index:
.kibana
. However, when the security plugin is installed, we noticed plugin failures in their tests. When the plugin is installed then this default index translates to theglobal
tenant. Digging deeper, we see that FTRepo's default tenant when the plugin is installed is theprivate
tenant. [source]. This equates to creating an index like.kibana_random_user
and it ends up causing failures in the tests because some functions and tests were not expecting this.For example: we can see the data explorer tests uses a bulk upload helper function to upload a fixture that uses
.kibana
. But this then becomes problematic because the actual saved objects, like index patterns, get pushed the global tenant but the test will navigate to a page referencing the private tenant. A common behavior we see is that OpenSearch Dashboards will see that the cluster has data indices but no index patterns so it will re-route tests to the index-patterns page by default and say please create an index pattern.Current mitigations proved successful to solve this issue:
#959
#1073
What solution would you like?
Since most of the tests are written using
.kibana
, we should switch the default tenant to be the global tenant. And modify the security plugin tests to switch to the private tenant.The text was updated successfully, but these errors were encountered: