Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][2.10] customImportMaps test flaky with security #883

Closed
kavilla opened this issue Sep 19, 2023 · 5 comments
Closed

[BUG][2.10] customImportMaps test flaky with security #883

kavilla opened this issue Sep 19, 2023 · 5 comments
Assignees
Labels
bug Something isn't working v2.11.0

Comments

@kavilla
Copy link
Member

kavilla commented Sep 19, 2023

PRs that skip tests when security enabled:

Requirements

  • Fix for the documentsSpec.
  • Fix for the opensearchMapLayer spec

Potentially related to this: #856

@kavilla kavilla added bug Something isn't working untriaged and removed untriaged labels Sep 19, 2023
@kavilla kavilla removed the untriaged label Sep 19, 2023
@junqiu-lei
Copy link
Member

Thanks @kavilla, when the #856 is resolved, I can help verify the fix of this issue

kavilla pushed a commit that referenced this issue Sep 20, 2023
Ignore the flaky test of opensearchMapLayer when security enabled

Issues Resolved
#883

Signed-off-by: Junqiu Lei <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Sep 20, 2023
Ignore the flaky test of opensearchMapLayer when security enabled

Issues Resolved
#883

Signed-off-by: Junqiu Lei <[email protected]>
(cherry picked from commit b5bdf48)
kavilla pushed a commit that referenced this issue Sep 25, 2023
…) (#885)

Ignore the flaky test of opensearchMapLayer when security enabled

Issues Resolved
#883

Signed-off-by: Junqiu Lei <[email protected]>
(cherry picked from commit b5bdf48)

Co-authored-by: Junqiu Lei <[email protected]>
@raintygao
Copy link
Collaborator

Hi @junqiu-lei , we need to fix or remove all flaky tests before 2.12 release, could your team take a look on this flaky test? As i found the related tests are skipped in this repo but not in dashboard-maps repo.

@junqiu-lei
Copy link
Member

The flaky tests only happened when security enabled, there are some other front plugin also have similar issue, I assume #856 need to be resolved firstly and then unblock flaky tests in plugins. cc @kavilla

@raintygao
Copy link
Collaborator

Hi @kavilla , is there any new insight about #856 ?

@junqiu-lei
Copy link
Member

I just have locally tested maps integration tests several times on 2.12 cluster with security enabled from docker-compose, I didn't see security related failures again, attached with videos. I think we can revert back run the tests when security enabled and close this issue for now. WDYT? @kavilla @raintygao

docker-compose.yml

docker-compose.yml

version: '3'
services:
opensearch-node1: # This is also the hostname of the container within the Docker network (i.e. https://opensearch-node1/)
  image: opensearchstaging/opensearch:2.12.0
  container_name: opensearch-node1
  environment:
    - cluster.name=opensearch-cluster # Name the cluster
    - node.name=opensearch-node1 # Name the node that will run in this container
    - discovery.seed_hosts=opensearch-node1,opensearch-node2 # Nodes to look for when discovering the cluster
    - cluster.initial_cluster_manager_nodes=opensearch-node1,opensearch-node2 # Nodes eligibile to serve as cluster manager
    - bootstrap.memory_lock=true # Disable JVM heap memory swapping
    - "OPENSEARCH_JAVA_OPTS=-Xms512m -Xmx512m" # Set min and max JVM heap sizes to at least 50% of system RAM
    - OPENSEARCH_INITIAL_ADMIN_PASSWORD=${OPENSEARCH_INITIAL_ADMIN_PASSWORD} # Sets the demo admin user password when using demo configuration (for OpenSearch 2.12 and later)
  ulimits:
    memlock:
      soft: -1 # Set memlock to unlimited (no soft or hard limit)
      hard: -1
    nofile:
      soft: 65536 # Maximum number of open files for the opensearch user - set to at least 65536
      hard: 65536
  volumes:
    - opensearch-data1:/usr/share/opensearch/data # Creates volume called opensearch-data1 and mounts it to the container
  ports:
    - 9200:9200 # REST API
    - 9600:9600 # Performance Analyzer
  networks:
    - opensearch-net # All of the containers will join the same Docker bridge network
opensearch-node2:
  image: opensearchstaging/opensearch:2.12.0
  container_name: opensearch-node2
  environment:
    - cluster.name=opensearch-cluster
    - node.name=opensearch-node2
    - discovery.seed_hosts=opensearch-node1,opensearch-node2
    - cluster.initial_cluster_manager_nodes=opensearch-node1,opensearch-node2
    - bootstrap.memory_lock=true
    - "OPENSEARCH_JAVA_OPTS=-Xms512m -Xmx512m"
    - OPENSEARCH_INITIAL_ADMIN_PASSWORD=${OPENSEARCH_INITIAL_ADMIN_PASSWORD}
  ulimits:
    memlock:
      soft: -1
      hard: -1
    nofile:
      soft: 65536
      hard: 65536
  volumes:
    - opensearch-data2:/usr/share/opensearch/data
  networks:
    - opensearch-net
opensearch-dashboards:
  image: opensearchstaging/opensearch-dashboards:2.12.0
  container_name: opensearch-dashboards
  ports:
    - 5601:5601 # Map host port 5601 to container port 5601
  expose:
    - "5601" # Expose port 5601 for web access to OpenSearch Dashboards
  environment:
    OPENSEARCH_HOSTS: '["https://opensearch-node1:9200","https://opensearch-node2:9200"]' # Define the OpenSearch nodes that OpenSearch Dashboards will query
  networks:
    - opensearch-net

volumes:
opensearch-data1:
opensearch-data2:

networks:
opensearch-net:
videos
add_saved_object.spec.js.mp4
documentsLayer.spec.js.mp4
import_vector_map_tab.spec.js.mp4
opensearchMapLayer.spec.js.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.11.0
Projects
None yet
Development

No branches or pull requests

3 participants