Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry for waitForSearch() helper function #950

Closed
abbyhu2000 opened this issue Nov 13, 2023 · 3 comments
Closed

Add retry for waitForSearch() helper function #950

abbyhu2000 opened this issue Nov 13, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request v2.12.0

Comments

@abbyhu2000
Copy link
Member

Within the data explorer tests, waitForSearch() is waiting for the discover table docTable to finish loading. However, sometimes the doc table takes too long to load, and will cause this function to fail.

For some of the flaky tests, we can add try and catch block for waitForSearch() and if it fails, try reloading the table; and if that fails again, throw an error.

@abbyhu2000 abbyhu2000 added enhancement New feature or request untriaged labels Nov 13, 2023
@ruanyl
Copy link
Member

ruanyl commented Dec 18, 2023

Hi @abbyhu2000 could you provide a bit more details about the flaky test? like the test file name and test cases. And do you plan to fix it in the coming release?

@abbyhu2000
Copy link
Member Author

@ruanyl The flaky tests are these: opensearch-project/OpenSearch-Dashboards#5495. After discussing with team, we decided to skip those flaky tests. I think we can close this issue.

@ruanyl
Copy link
Member

ruanyl commented Dec 20, 2023

@abbyhu2000 Thanks for the update, looks like you're tracking the flaky test in OSD repo, then I'll close this issue now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.12.0
Projects
None yet
Development

No branches or pull requests

3 participants